From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Jörgen Sigvardsson" <jorgen.sigvardsson@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libwebsockets: option for building with LWS_WITH_ZIP_FOPS
Date: Sun, 21 Aug 2022 22:13:01 +0200 [thread overview]
Message-ID: <20220821201301.GT2167049@scaer> (raw)
In-Reply-To: <20220211081357.40439-1-jorgen.sigvardsson@gmail.com>
Jörgen, All,
Sorry for the later feedback.
On 2022-02-11 09:13 +0100, Jörgen Sigvardsson spake thusly:
> Signed-off-by: Jörgen Sigvardsson <jorgen.sigvardsson@gmail.com>
> ---
> +if BR2_PACKAGE_LIBWEBSOCKETS
> +
> +config BR2_PACKAGE_LIBWEBSOCKETS_ZIP_FOPS
> + bool "enable serving files from zip archives"
> + default y
Options should not default to y, unless for backward compatibility.
> + help
> + By enabling this flag, files can be served from a (preferably
> + uncompressed) zip file. Furthermore, the contained files can
> + be gzipped. Gzipped files may be delivered as-is (no deflation
> + needed) to clients that accept gzipped encoded contents (all
> + modern browsers do that).
This is all a bit confusing... "Uncompressed zipfiles that can contain
gzipped files, which can be served as-is..."
Maybe just duplicate the help text of the corresponding option:
option(LWS_WITH_ZIP_FOPS "Support serving pre-zipped files" OFF)
> +ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_ZIP_FOPS),y)
> +LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_ZIP_FOPS=ON
> +endif
The option must be explicitly disabled:
ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS_ZIP_FOPS),y)
LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_ZIP_FOPS=ON
else
LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_ZIP_FOPS=OFF
endif
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-08-21 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 8:13 [Buildroot] [PATCH 1/1] package/libwebsockets: option for building with LWS_WITH_ZIP_FOPS Jörgen Sigvardsson
2022-04-01 7:42 ` Joachim Wiberg
2022-08-21 20:13 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220821201301.GT2167049@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=jorgen.sigvardsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox