Re: [Buildroot] [PATCH v4 1/2] boot/arm-trusted-firmware: allow to generate BL2 from RCW

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Tue, 16 Aug 2022 19:55:02 +0200
Francois Perrad <fperrad@gmail.com> wrote:

> This patch adds option BR2_TARGETARM_TRUSTED_FIRMWARE_RCW that allows
> TF-A to encapsulate a pre-loader RCW (Reset Configuration Word) file
> into BL2.
> 
> Upcoming NXP QorIQ family board needs this option.
> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Thanks, I have applied with some changes.

> ---
>  boot/arm-trusted-firmware/Config.in               | 6 ++++++
>  boot/arm-trusted-firmware/arm-trusted-firmware.mk | 6 ++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/boot/arm-trusted-firmware/Config.in b/boot/arm-trusted-firmware/Config.in
> index 100ac8348..2a59a325d 100644
> --- a/boot/arm-trusted-firmware/Config.in
> +++ b/boot/arm-trusted-firmware/Config.in
> @@ -90,6 +90,12 @@ config BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP
>  	  platforms were ATF encapsulates the second stage bootloader
>  	  (such as U-Boot).
>  
> +config BR2_TARGET_ARM_TRUSTED_FIRMWARE_RCW

I have moved this option further down, next to the options where we can
say what BL32 to use, what BL33 to use. It made more sense to me than
to have the option in the middle of the list of images to build.

> +	bool "Include RCW"

Changed to "Include NXP RCW" to hint it's some NXP-specific stufff.

> +	select BR2_PACKAGE_HOST_QORIQ_RCW

Changed to "depends on". Indeed, sub-options of
BR2_PACKAGE_HOST_QORIQ_RCW must be set for this to work correctly, so
the user needs to be aware that qoriq-rcw is used.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot