Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Alexey Brodkin via buildroot <buildroot@buildroot.org>
Cc: buildroot@busybox.net,
	Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	l.stelmach@samsung.com
Subject: Re: [Buildroot] [PATCH] arch: Set common-page-size explicitly
Date: Tue, 23 Aug 2022 23:53:16 +0200	[thread overview]
Message-ID: <20220823235316.6fa50911@windsurf> (raw)
In-Reply-To: <20220815171744.105903-1-abrodkin@synopsys.com>

On Mon, 15 Aug 2022 10:17:44 -0700
Alexey Brodkin via buildroot <buildroot@buildroot.org> wrote:

> On some CPU architecures it's possible to use MMU pages of different
> sizes. Those are for example are ARC & ARM. And while for use-space
> applications page size is supposed to be transparent, there's still
> some use of that extra information. In particular it's possible to
> align data structures or code/data sections on page boundary, etc.
> 
> For these tricks to become possible tools which pack data (think of
> the linker, like GNU "ld") need to be informed of the page size to
> be considered.
> 
> Obviously, there're some sane defaults which are being used most of
> the time, so we even think about that peculiarity, but when non-default
> value needs to be used, GNU "ld" accepts 2 properties related to page
> size:
> 
>  -z common-page-size=XXX
>  -z max-page-size=YYY
> 
> And while in thery those might be different (but always "common" <= "max"),
> and that might make sense if we build for some unknown platfrom,
> in case of Buildroot when we build entire target's filesystem and so
> know exactly the configuration we're targeting to, we may safely assume
> "common-page-size"="max-page-size".
> 
> See a lengthly discussions in this thread [1].
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/c8b2f331c98453670cd982558144c4fd84674a3d/ (uclibc)
>   http://autobuild.buildroot.net/results/3a22f7aac38145b26c549254b819f87329e7a77e/ (glibc)
> 
> And while at it, recover use of "XX-page-size" for ARC, as with [2]
> moving page size selection in the generic code we've got unexpected
> override for ARC (note "=", but not "+="):
> --------------------->8--------------------  
> ARCH_TOOLCHAIN_WRAPPER_OPTS = -matomic
> --------------------->8--------------------  

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-08-23 21:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 17:17 [Buildroot] [PATCH] arch: Set common-page-size explicitly Alexey Brodkin via buildroot
2022-08-23 21:53 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220823235316.6fa50911@windsurf \
    --to=buildroot@buildroot.org \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=buildroot@busybox.net \
    --cc=l.stelmach@samsung.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox