Re: [Buildroot] [PATCH 1/1] package/qt6/qt6base: extend qt6 configuration

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Jesse Van Gavere <jesseevg@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qt6/qt6base: extend qt6 configuration
Date: Thu, 25 Aug 2022 10:43:42 +0200	[thread overview]
Message-ID: <20220825104342.61d691ac@windsurf> (raw)
In-Reply-To: <20220825073951.3920874-1-jesseevg@gmail.com>

Hello Jesse,

On Thu, 25 Aug 2022 09:39:51 +0200
Jesse Van Gavere <jesseevg@gmail.com> wrote:

> This will bring the qt6base functionality mostly on par with the qt5base
> package, building the package has been tested to the best of my ability
> and went without error as far as I can test.
> One bug to be noted is that for the GUI with fontconfig without harfbuzz
> support, this will produce incorrectly rendered text for version 6.3.1,
> see https://bugreports.qt.io/browse/QTBUG-101430
> I have however already verified that 6.3.2 and 6.4.0 will fix this issue
> so I've decided not to add harfbuzz as a fontconfig dependency as a
> version bump (which should be soon) will fix it.

Yes, let's bump to 6.4.0 then.

> Also add the version hashes for qt6base.
> 
> Signed-off-by: Jesse Van Gavere <jesseevg@gmail.com>

Overall, this needs to be split into a number of patches:

 - One adding the hash file, with just the hash of the tarball

 - One adding the license information (which is totally missing today,
   and I noticed due to your addition of the hash file) together with
   the hashes of the license files

 - Several patches adding the different options. I'm not too keen on
   copy/pasting directly the qt5 logic, as I'm not sure all the
   dependencies are exactly the same, so let's do this one feature at a
   time.

> +ifeq ($(BR2_ENABLE_DEBUG),y)
> +QT6BASE_CONF_OPTS += -DCMAKE_BUILD_TYPE=Debug
> +else
> +QT6BASE_CONF_OPTS += -DCMAKE_BUILD_TYPE=Release
> +endif

This is already handled by the cmake-package infrastructure, do no need
to handle CMAKE_BUILD_TYPE.

> +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> +# Qt 5.8 needs atomics, which on various architectures are in -latomic
> +QT6BASE_CONF_OPTS += -DCMAKE_SHARED_LINKER_FLAGS="-latomic"

Is this also needed with Qt6 ? (Most likely yes, but the comment is
weird, another reason why I don't like the copy/pasting from Qt5).

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot