Re: [Buildroot] [PATCH 1/1] package/musl-fts: always build static library

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Lance, All,

Please, be sure that the From header matches your SoB line; evne though
your email matches, the From lacks your real name.

On 2022-08-24 14:26 -0600, lancethepants spake thusly:
> musl-fts provides features left out of musl that are included in other libc's.
> 
> This patch always enables building the static library so
> that it is always present with musl's libc.a when enabled.
> 
> For those that are using buildroot for toolchain creation
> and want to static link, then libfts.a is available.

Sorry, I am not sure I totally understood what you meant here.

If I understood correctly, you want to use Buildroot, to generate a
musl-based toolchain, that you can distribute. You want that that
toolchain be usable to do both shared and static linking. Right?

Then you want to be able to use that toolchain to build some software
that uses fts(3). And so, since you want to allow static-only linking,
you want that toolchain to also include the fts library as a static
library.

However, this is, in my opinion, problematic for a few reasons.

First, including musl-ftx under the toolchain denomination is wrong; it
no longer is a toolchain, but more of an SDK. Including musl-fts will
for example mean that that toolchain will not be reusable as an external
toolchain for Buildroot, because then musl-fts in the toolchain will
come conflicting with musl-fts the package in Buildroot.

Second, if you need both static and shared libraries, why don't you
build your SDK with BR2_SHARED_STATIC_LIBS to begin with? With that, we
pass both --enable-static --enable-shared when building autotools
packages (and musl-fts is an autotools package); see package/Makefile.in
lines 423-424.

Third, what makes musl-fts different from other libraries that may be
included in the SDK? If your external software needs other libraries,
and you do not have them in the SDK, then you'll have to build those
libraries first, and point your software buildsystem to use them; why
can't you do the same for musl-fts?

> Signed-off-by: Lance Fredrickson <lancethepants@gmail.com>
> Signed-off-by: lancethepants <lancethepants@gmail.com>

That second SoB line is incorrect, as it has no real-name part; it is
also superfluous, because it is the same email part.

Regards,
Yann E. MORIN.

> ---
>  package/musl-fts/musl-fts.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/musl-fts/musl-fts.mk b/package/musl-fts/musl-fts.mk
> index dd7f1f9ea0..fcad9c3d75 100644
> --- a/package/musl-fts/musl-fts.mk
> +++ b/package/musl-fts/musl-fts.mk
> @@ -12,5 +12,6 @@ MUSL_FTS_LICENSE_FILES = COPYING
>  # pkg-config needed for autoreconf
>  MUSL_FTS_DEPENDENCIES = host-pkgconf
>  MUSL_FTS_INSTALL_STAGING = YES
> +MUSL_FTS_CONF_OPTS += --enable-static
>  
>  $(eval $(autotools-package))
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot