Re: [Buildroot] [PATCH] package/mbedtls: add configurable SRTP support

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Dmitry Ilyin <dima@doty.ru>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mbedtls: add configurable SRTP support
Date: Sun, 28 Aug 2022 20:59:43 +0200	[thread overview]
Message-ID: <20220828185943.GR37358@scaer> (raw)
In-Reply-To: <20220828155304.4398-1-dima@doty.ru>

Dmitry, All,

On 2022-08-28 18:53 +0300, Dmitry Ilyin spake thusly:
> This adds new BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT option to have MbedTLS
> builds that support SRTP (required option for AWS WebRTC library)

I've slightly reworded the commit log.

> Signed-off-by: Dmitry Ilyin <dima@doty.ru>
> ---
>  package/mbedtls/Config.in  | 6 ++++++
>  package/mbedtls/mbedtls.mk | 8 ++++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/package/mbedtls/Config.in b/package/mbedtls/Config.in
> index a39ba65d98..f06a27fc5c 100644
> --- a/package/mbedtls/Config.in
> +++ b/package/mbedtls/Config.in
> @@ -29,4 +29,10 @@ config BR2_PACKAGE_MBEDTLS_COMPRESSION
>  	  sure CRIME and similar attacks are not applicable to your
>  	  particular situation.
>  
> +config BR2_PACKAGE_MBEDTLS_SRTP

I've renamed the option to BR2_PACKAGE_MBEDTLS_DTLS_SRTP because this is
what it drives: support for DTLS-SRTP.

> +	bool "enable SRTP support"
> +	help
> +	  Enable support for negotiation of DTLS-SRTP (RFC 5764)
> +	  through the use_srtp extension.
> +
>  endif
> diff --git a/package/mbedtls/mbedtls.mk b/package/mbedtls/mbedtls.mk
> index af87d62b30..9f9aee1fec 100644
> --- a/package/mbedtls/mbedtls.mk
> +++ b/package/mbedtls/mbedtls.mk
> @@ -72,4 +72,12 @@ else ifeq ($(BR2_microblaze)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y)
>  MBEDTLS_POST_CONFIGURE_HOOKS += MBEDTLS_DISABLE_ASM
>  endif
>  
> +ifeq ($(BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT),y)

The variable was not what it is named in the Config.in. Anyway, I also
renamed it accordingly.

> +define MBEDTLS_ENABLE_SRTP

And I have also renamed the hook.

Applied to next, thanks.

Regards,
Yann E. MORIN.

> +	$(SED) "s://#define MBEDTLS_SSL_DTLS_SRTP:#define MBEDTLS_SSL_DTLS_SRTP:" \
> +		$(@D)/include/mbedtls/config.h
> +endef
> +MBEDTLS_POST_PATCH_HOOKS += MBEDTLS_ENABLE_SRTP
> +endif
> +
>  $(eval $(cmake-package))
> -- 
> 2.37.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot