From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/collectd: disable libupsclient
Date: Mon, 29 Aug 2022 10:07:28 +0200 [thread overview]
Message-ID: <20220829080728.GU37358@scaer> (raw)
In-Reply-To: <20220829073024.GT37358@scaer>
Fabrice, All,
On 2022-08-29 09:30 +0200, Yann E. MORIN spake thusly:
> On 2022-08-29 00:17 +0200, Fabrice Fontaine spake thusly:
> > Disable libupsclient to avoid the following build failure if
> > libupsclient is installed on host:
[--SNIP--]
> However, I think a better fix would be to understand why this breaks,
> even though we do have nut enabled in the config, and collectd's
> configure did detect it correctly.
[--SNIP--]
> So, the detection fails, not because of the upsclient is missing (it is
> not!), but because the detection fails. Why does that toolchan not have
> the time_t type defined? It is a musl toolchain, so maybe, just maybe?
Maybe something in nut, along the lines of (totally untested):
diff --git a/clients/upsclient.h b/clients/upsclient.h
index 08574b8f8..8f7a95759 100644
--- a/clients/upsclient.h
+++ b/clients/upsclient.h
@@ -41,6 +41,10 @@
#include <limits.h>
#endif
+#if defined HAVE_TIME_H
+ #include <time.h>
+#endif
+
#ifdef __cplusplus
/* *INDENT-OFF* */
extern "C" {
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-08-29 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-28 22:17 [Buildroot] [PATCH 1/1] package/collectd: disable libupsclient Fabrice Fontaine
2022-08-29 7:30 ` Yann E. MORIN
2022-08-29 8:07 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829080728.GU37358@scaer \
--to=yann.morin.1998@free.fr \
--cc=asafka7@gmail.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox