From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Raphael Pavlidis <raphael.pavlidis@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/shadow: new package
Date: Mon, 5 Sep 2022 14:01:03 +0200 [thread overview]
Message-ID: <20220905120103.GD1490660@scaer> (raw)
In-Reply-To: <20220905115121.GC1490660@scaer>
Raphael, All,
On 2022-09-05 13:51 +0200, Yann E. MORIN spake thusly:
> On 2022-09-04 14:43 +0200, Raphael Pavlidis spake thusly:
> > shadow provides utilities to deal with user accounts.
[--SNIP--]
> > +ifeq ($(BR2_STATIC_LIBS),y)
> > +SHADOW_CONF_OPTS += --enable-static
> > +else
> > +SHADOW_CONF_OPTS += --disable-static
> > +endif
> > +
> > +ifeq ($(BR2_SHARED_LIBS),y)
> > +SHADOW_CONF_OPTS += --enable-shared
> > +else
> > +SHADOW_CONF_OPTS += --disable-shared
> > +endif
> So, first, both options are already passed appropriately by the
> autotools package infrastructure, so why do you need to pass them?
> Second, --{en,disable}-{static,shared} is supposed to drive the build
> of static or shared libraries, not the fact that anything is shared or
> statically linked.
Oh, and of course, Buildroot can be configured with neither
BR2_STATIC_LIBS nor BR2_SHARED_LIBS, but with BR2_SHARED_STATIC_LIBS,
which means to generate both static and shared, but the code above would
actually disable both.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-05 12:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 12:43 [Buildroot] [PATCH v2 1/1] package/shadow: new package Raphael Pavlidis
2022-09-05 10:06 ` Arnout Vandecappelle
2022-09-05 11:51 ` Yann E. MORIN
2022-09-05 12:01 ` Yann E. MORIN [this message]
2022-09-11 11:22 ` Raphael Pavlidis
2022-09-11 12:14 ` Yann E. MORIN
2022-09-11 12:55 ` Raphael Pavlidis
2022-09-11 17:57 ` Yann E. MORIN
2022-10-13 16:34 ` [Buildroot] [PATCH v3 " Raphael Pavlidis
2022-12-05 15:48 ` Nicolas Carrier
2022-12-05 21:55 ` Yann E. MORIN
2022-12-06 18:20 ` Raphael Pavlidis
2022-12-08 15:15 ` Nicolas Carrier
2022-12-09 10:24 ` Raphael Pavlidis
2022-12-09 11:07 ` Nicolas Carrier
2022-12-10 8:28 ` Yann E. MORIN
2022-12-16 9:42 ` Raphael Pavlidis
2022-12-16 14:34 ` Nicolas Carrier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905120103.GD1490660@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=raphael.pavlidis@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox