From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Christian Stewart <christian@paral.in>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v1 1/1] package/docker-compose: bump to version 2.10.0
Date: Mon, 5 Sep 2022 16:08:13 +0200 [thread overview]
Message-ID: <20220905140813.GE1490660@scaer> (raw)
In-Reply-To: <CA+h8R2pXVEsdxhtuwNNqm-kdE_XdLwjbQLDWNGE4k7=_qrWzgA@mail.gmail.com>
Christian, All,
On 2022-09-04 13:02 -0700, Christian Stewart spake thusly:
> On Sun, Sep 4, 2022 at 12:41 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2022-09-04 12:10 -0700, Christian Stewart via buildroot spake thusly:
> > > Docker Compose v2 is a CLI plugin loaded by docker-cli.
> > So, if it is a plugin for docker-cli...
> I thought about doing that, with docker-compose in a sub-menu under DOCKER_CLI.
Not in a sub-menu, but as a separate package that depends on docker-cli.
> But given that historically it was a separate package, and people may
> not necessarily realize it's a plugin,
It happens al the time that, when we bump a package version, it gains ne
dependencies. We do nt have a good mechanism for that, except people can
run utils/diffconfig to check their .config files before and after they
update to newer Buildroot version.
> I instead decided to just `select BR2_PACKAGE_DOCKER_CLI` if
> DOCKER_COMPOSE is enabled.
I see the reasoning, but I still think the select should be switched to
a depends on.
> Do you want me to re-submit it with the plugin style instead?
No need, it is trivial to do when applying.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-05 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 19:10 [Buildroot] [PATCH v1 1/1] package/docker-compose: bump to version 2.10.0 Christian Stewart via buildroot
2022-09-04 19:41 ` Yann E. MORIN
2022-09-04 20:02 ` Christian Stewart via buildroot
2022-09-05 14:08 ` Yann E. MORIN [this message]
2022-09-06 8:22 ` Yann E. MORIN
2022-10-31 22:02 ` Thomas Petazzoni via buildroot
2022-10-31 22:08 ` Christian Stewart via buildroot
2022-10-31 22:31 ` Thomas Petazzoni via buildroot
2022-11-01 0:32 ` Christian Stewart via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905140813.GE1490660@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=christian@paral.in \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox