From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] Makefile: unexport TARGET env variable
Date: Tue, 6 Sep 2022 09:21:58 +0200 [thread overview]
Message-ID: <20220906072158.GM1490660@scaer> (raw)
In-Reply-To: <20220905202002.4183680-1-james.hilliard1@gmail.com>
James, All,
On 2022-09-05 14:20 -0600, James Hilliard spake thusly:
> If set this can may break package builds in some cases such as the
So, this is very probabilistic: 'can' and 'may'! ;-)
> host-icu build.
Can you provide an actual error message and an explanation on how that
actually fails?
I've looked at the icu source code, and all I could see are plain
assignments and references to TARGET. Variables assigned in a Makefile
are supposed to take precedence to variables from the environment, so I
am not sure I can see how that can actually fail...
See for example commits which describes the actual reasons it fails:
20ca008d0266 unexport TERMINFO to correct ncurses behavior
2e32330c4a49 Makefile: unexport O
d3910057c6ae Makefile: unexport 'DEVICE_TREE' environment variable
6cff741ebaf7 package/ccache: do not force colored diagnostics
Regards,
Yann E. MORIN.
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index bd0b906cde..a82a22a276 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -427,6 +427,7 @@ unexport GCC_COLORS
> unexport PLATFORM
> unexport OS
> unexport DEVICE_TREE
> +unexport TARGET
>
> GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
>
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-06 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 20:20 [Buildroot] [PATCH 1/1] Makefile: unexport TARGET env variable James Hilliard
2022-09-06 7:21 ` Yann E. MORIN [this message]
2022-09-06 21:15 ` James Hilliard
2022-09-07 12:42 ` Arnout Vandecappelle
2022-09-07 22:51 ` James Hilliard
2022-09-09 19:31 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906072158.GM1490660@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox