Re: [Buildroot] [PATCH] package/sox: work around gcc bug 68485

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/sox: work around gcc bug 68485
Date: Sat, 10 Sep 2022 09:05:48 +0200	[thread overview]
Message-ID: <20220910070548.GD264214@scaer> (raw)
In-Reply-To: <20220909221559.1417171-1-giulio.benetti@benettiengineering.com>

Giulio, All,

On 2022-09-10 00:15 +0200, Giulio Benetti spake thusly:
> With Microblaze Gcc version <= 12.x the build fails due to gcc bug 68485:

Since the latest gcc versin is 12.x, then "gcc <= 12.x" actually means
all versions of gcc, no?

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. The bug show up when
> building sox with optimization but not when building with -O0. To work
> around this, if BR2_TOOLCHAIN_HAS_GCC_BUG_68458=y, we force using -O0.
> 
> Fixes:
> http://autobuild.buildroot.net/results/ac4/ac4fbd55529ac7b4e635a11766f842cd25a833a1/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/sox/sox.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/package/sox/sox.mk b/package/sox/sox.mk
> index 1896437ad4..d0329bf50d 100644
> --- a/package/sox/sox.mk
> +++ b/package/sox/sox.mk
> @@ -26,6 +26,14 @@ SOX_CONF_OPTS = \
>  	--with-distro="Buildroot" \
>  	--disable-stack-protector
>  
> +SOX_CFLAGS = $(TARGET_CFLAGS)
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)

Since you said the bug only appears for microblaze, gcc <= 12, and this
specific gcc bug, then shouldn't all three conditions be used?
(excluding gcc version because of my earlier comment):

    ifeq ($(BR2_microblaze)$(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),yy)

I.e. there is no reason to penalise other architectures, since only
micrbolaze is impacted by that bug.

Regards,
Yann E. MORIN.

> +SOX_CFLAGS += -O0
> +endif
> +
> +SOX_CONF_ENV += CFLAGS="$(SOX_CFLAGS)"
> +
>  ifeq ($(BR2_PACKAGE_ALSA_LIB_PCM),y)
>  SOX_DEPENDENCIES += alsa-lib
>  SOX_CONF_OPTS += --enable-alsa
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot