Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Ignacy Gawędzki" <ignacy.gawedzki@green-communications.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3] package/chartjs: bump to version 3.9.1
Date: Sat, 17 Sep 2022 15:17:55 +0200	[thread overview]
Message-ID: <20220917151755.6dfaeb1b@windsurf> (raw)
In-Reply-To: <20220913093235.wdaiq5lsy3mbcc6u@zenon.in.qult.net>

Hello Ignacy,

On Tue, 13 Sep 2022 11:32:35 +0200
Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr> wrote:

> Install only minified Javascript source.  No more CSS required.
> 
> https://github.com/chartjs/Chart.js/releases/tag/v3.9.1
> 
> License file has updated copyright years to 2014-2022.
> 
> Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr>
> ---
>  package/chartjs/Config.in    |  3 +++
>  package/chartjs/chartjs.hash |  4 ++--
>  package/chartjs/chartjs.mk   | 14 ++++++++------
>  3 files changed, 13 insertions(+), 8 deletions(-)
> 
> diff --git a/package/chartjs/Config.in b/package/chartjs/Config.in
> index 73cc9b7750..c1cc717410 100644
> --- a/package/chartjs/Config.in
> +++ b/package/chartjs/Config.in
> @@ -1,4 +1,7 @@
>  config BR2_PACKAGE_CHARTJS
> +	depends on BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS # host-nodejs
> +	depends on BR2_HOST_GCC_AT_LEAST_8 # host-nodejs
> +	select BR2_PACKAGE_HOST_NODEJS
>  	bool "chartjs"
>  	help
>  	  Chart.js, a simple yet flexible JavaScript charting library
> diff --git a/package/chartjs/chartjs.hash b/package/chartjs/chartjs.hash
> index f8614ec385..85f131df40 100644
> --- a/package/chartjs/chartjs.hash
> +++ b/package/chartjs/chartjs.hash
> @@ -1,3 +1,3 @@
>  # Locally computed:
> -sha256  9ef3697e279a585c79730f35dba16ad4e24ddeed49a150adb341c31f191fb78e  chartjs-2.9.4.tar.gz
> -sha256  7b43caae91f31b18dc81fae6e0f7aa1acbecaa6d84e3249905cbe15308307d67  LICENSE.md
> +sha256  b94faf2699d1d3b44f8733b0d380c7db72c46dbccef7008ac88f2fec5bc4eb25  chartjs-3.9.1.tar.gz
> +sha256  5a0877ad6d818529be4f33009d0942cdf7e2ed7656156f4aba7308459a546030  LICENSE.md
> diff --git a/package/chartjs/chartjs.mk b/package/chartjs/chartjs.mk
> index 2748a94d36..720fa25091 100644
> --- a/package/chartjs/chartjs.mk
> +++ b/package/chartjs/chartjs.mk
> @@ -4,20 +4,22 @@
>  #
>  ################################################################################
>  
> -CHARTJS_VERSION = 2.9.4
> +CHARTJS_VERSION = 3.9.1
>  CHARTJS_SITE = $(call github,chartjs,Chart.js,v$(CHARTJS_VERSION))
>  CHARTJS_LICENSE = MIT
>  CHARTJS_LICENSE_FILES = LICENSE.md
>  CHARTJS_CPE_ID_VENDOR = chartjs
>  CHARTJS_CPE_ID_PRODUCT = chart.js
>  
> +CHARTJS_DEPENDENCIES = host-nodejs
> +
> +define CHARTJS_BUILD_CMDS
> +	cd $(@D) && $(NPM) install && $(NPM) run build

This is a bit worrying. What does it do? Does it download/install
additional stuff? If so, it breaks reproducibility of the build, the
download infrastructure logic, the legal-info logic, etc.

Could you provide more background on this?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-09-17 13:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13  9:32 [Buildroot] [PATCH v3] package/chartjs: bump to version 3.9.1 Ignacy Gawędzki
2022-09-17 13:17 ` Thomas Petazzoni [this message]
2022-09-19  9:16   ` Ignacy Gawędzki
2022-09-19  9:46     ` Thomas Petazzoni via buildroot
2022-09-22 13:34       ` Ignacy Gawędzki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220917151755.6dfaeb1b@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=ignacy.gawedzki@green-communications.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox