Re: [Buildroot] [PATCH next 1/1] package/rdma-core: new package

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Julien,

On Sun, 21 Aug 2022 18:01:43 +0200
Julien Olivain <ju.o@free.fr> wrote:

> This is the userspace components for the Linux Kernel's
> drivers/infiniband subsystem.
> 
> https://github.com/linux-rdma/rdma-core
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>

Thanks for this patch. It looks really good. I have just a few
questions and one super minor comment, see below.

> diff --git a/package/rdma-core/readme.txt b/package/rdma-core/readme.txt
> new file mode 100644
> index 0000000000..4f90720ca3
> --- /dev/null
> +++ b/package/rdma-core/readme.txt
> @@ -0,0 +1,74 @@
> +Testing rdma-core userspace tools
> +=================================
> +
> +Testing rdma-core using Linux software RoCE implementation:
> +https://en.wikipedia.org/wiki/RDMA_over_Converged_Ethernet
> +
> +Using two systems with working TCP/IP conficutation, for example:

                                         ^^^^^^^ minor typo here

> +Kernel configuration
> +--------------------
> +
> +The Linux Kernel needs some Infiniband configuration. In this example
> +the kernel "rdma_rxe" driver is needed (CONFIG_RDMA_RXE=y). See the
> +example fragment file provided:
> +
> +    package/rdma-core/linux-rdma.fragment

Did you consider using the <pkg>_LINUX_CONFIG_FIXUPS variable instead?
This would make sure these configuration options are always enabled in
the kernel. Or is your fragment just an example?

> +Buildroot package configuration
> +-------------------------------
> +
> +For setting up a software RoCE link, the "rdma" program is needed. It
> +is provided by the "iproute2" package, when "libmnl" is also
> +selected. Make sure to have in your Buildroot configuration:
> +
> +    BR2_PACKAGE_IPROUTE2=y
> +    BR2_PACKAGE_LIBMNL=y
> +    BR2_PACKAGE_RDMA_CORE=y

Then is there a reason to not select iproute2 and libmnl? Or is it just
that they are needed only for specific use cases?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot