From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [git commit] utils/genrandconfig: disable libopenssl without atomics
Date: Sun, 18 Sep 2022 17:18:44 +0200 [thread overview]
Message-ID: <20220918151844.GJ1419013@scaer> (raw)
In-Reply-To: <20220918134912.03172851A2@busybox.osuosl.org>
Fabrice, All,
On 2022-09-18 15:36 +0200, Arnout Vandecappelle spake thusly:
> commit: https://git.buildroot.net/buildroot/commit/?id=af494d92d3d065a8939f0567bfbf312d177048f2
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> libopenssl needs atomic or the build will fail (e.g. on sparcv8 without
> libatomic):
[--SNIP--]
> diff --git a/utils/genrandconfig b/utils/genrandconfig
> index 7fd17239c5..efa73e938d 100755
> --- a/utils/genrandconfig
> +++ b/utils/genrandconfig
> @@ -247,6 +247,11 @@ def fixup_config(sysinfo, configfile):
> if 'BR2_ARM_CPU_ARMV7M=y\n' in configlines and \
> 'BR2_PACKAGE_LIBFFI=y\n' in configlines:
> return False
> + # libopenssl needs atomic, but propagating this dependency in
> + # Buildroot is really too much work, so we handle this here.
> + if 'BR2_PACKAGE_LIBOPENSSL=y\n' in configlines and \
> + not 'BR2_TOOLCHAIN_HAS_ATOMIC=y\n' in configlines:
This triggers a flake8 warning:
https://gitlab.com/buildroot.org/buildroot/-/jobs/3045260108
$ make check-flake8
utils/genrandconfig:253:8: E713 test for membership should be 'not in'
1 E713 test for membership should be 'not in'
I've pushed a fix with commit fa538315dc02 (utils/genrandconfig: fix
flake8).
Regards,
Yann E. MORIN.
> + return False
> if 'BR2_PACKAGE_SUNXI_BOARDS=y\n' in configlines:
> configlines.remove('BR2_PACKAGE_SUNXI_BOARDS_FEX_FILE=""\n')
> configlines.append('BR2_PACKAGE_SUNXI_BOARDS_FEX_FILE="a10/hackberry.fex"\n')
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-18 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 13:36 [Buildroot] [git commit] utils/genrandconfig: disable libopenssl without atomics Arnout Vandecappelle
2022-09-18 15:18 ` Yann E. MORIN [this message]
2022-09-29 13:54 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220918151844.GJ1419013@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox