Re: [Buildroot] [PATCH v3] Makefile: fix use of many br2-external trees

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Arnout, All,

On 2022-09-21 20:32 +0200, Arnout Vandecappelle spake thusly:
> On 21/09/2022 20:13, Thomas Petazzoni wrote:
> >On Tue, 20 Sep 2022 21:46:45 +0200
> >"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> >>One of the rationale behind this code, is that we want the defconfig
> >>files from br2-external trees further down the list, to override
> >>defconfig files from those earlier in the list, even overriding the
> >>defconfig files from Buildroot itself.
> >This is the part I would like to challenge. Why do we want to allow
> >BR2_EXTERNAL to override defconfigs from the main tree? We do not allow
> >this for packages, why should we allow it for defconfigs?
>  And indeed, this is exactly the reverse of what we would have now. We have
> two pattern rules that match with the same stem. In this case, according to
> 'info make': "'make' will choose the first one found in the makefile." Since
> we put $(TOPDIR) before the externals in the foreach loop, the internal one
> will be the one that gets used.

As discussed on IRC: except we do not put TOPDIR first; we do:
    $(call reverse,TOPDIR BR2_EXTERNALS)

so the last external does win.

I.e. that patch does not change the current behaviour; it just fixes the
use of more than 5 br2-extenal trees at once.

Sorry, I may not have been clear about the explanations in my commit
log: the rationale part refers to the current code, not the change I
did. Whoever applies it can amend as they see fit, or I can respin if
needed.

Oh, and by the way, I got that privately, so I'll paste it here so that
patchwork catches it:

Tested-by: David Lawson <david.lawson1@tx.rr.com>

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot