From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Frank Hunleth via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/erlang: support aarch64 host-erlang builds
Date: Fri, 23 Sep 2022 23:42:47 +0200 [thread overview]
Message-ID: <20220923234247.3297fc48@windsurf> (raw)
In-Reply-To: <20220921204916.3420825-1-fhunleth@troodon-software.com>
Hello Frank,
On Wed, 21 Sep 2022 20:49:59 +0000
Frank Hunleth via buildroot <buildroot@buildroot.org> wrote:
> This fixes the following warning when building erlang on aarch64
> machines:
>
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_ERLANG
> Depends on [n]: BR2_USE_MMU [=y] && !BR2_STATIC_LIBS [=n] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_PACKAGE_ERLANG_ARCH_SUPPORTS [=n]
>
> Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>
> ---
> package/erlang/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/erlang/Config.in b/package/erlang/Config.in
> index 15931b5896..5198f35efc 100644
> --- a/package/erlang/Config.in
> +++ b/package/erlang/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_HOST_ERLANG_ARCH_SUPPORTS
> bool
> default y if BR2_HOSTARCH = "x86_64"
> default y if BR2_HOSTARCH = "x86"
> + default y if BR2_HOSTARCH = "aarch64"
While I appreciate that adding support for aarch64 as a host
architecture for Erlang is a good idea, this cannot be the proper fix
for the circular dependency you're seeing, as it means the same issue
will happen on another host architecture.
Do you have the example configuration that exhibits the problem? I
don't see any place that selects BR2_PACKAGE_ERLANG in the tree.
Perhaps you're seeing this with a custom package of yours that has
"select BR2_PACKAGE_ERLANG", but forgot "depends on
BR2_PACKAGE_ERLANG_ARCH_SUPPORTS" ?
Don't get me wrong: the patch is correct, but its commit log and the
reasoning looks suspicious.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-09-23 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 20:49 [Buildroot] [PATCH] package/erlang: support aarch64 host-erlang builds Frank Hunleth via buildroot
2022-09-23 21:42 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923234247.3297fc48@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox