From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Gwenhael Goavec-Merou <gwenj@trabucayre.com>
Cc: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3] package/gnuradio: bump version to 3.10.4.0
Date: Fri, 23 Sep 2022 23:51:49 +0200 [thread overview]
Message-ID: <20220923235149.5b312376@windsurf> (raw)
In-Reply-To: <1663937486-98556-1-git-send-email-gwenj@trabucayre.com>
Hello,
On Fri, 23 Sep 2022 14:51:26 +0200
Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:
> Note:
> Since gnuradio 3.10 swig was replaced by pybind. Now python libraries
> and python wrappers are produces using pybind: this why pybind is a
> buildtime and runtime dependency. numpy also become a buildtime dependency
> since some cpp bindings uses numpy's functions directly: this library
> is now required in both situation.
I am sorry, but this is still not clear. In this text, nowhere you are
talking about "host" or "target" packages.
> - select BR2_PACKAGE_PYTHON_NUMPY # runtime
> + select BR2_PACKAGE_PYTHON_NUMPY
This change is incorrect: target numpy is still only a runtime
dependency. Your change to gnuradio.mk adds host-python-numpy as a
build-time dependency, but not python-numpy.
Remember:
- Target packages are named "foo" and have a corresponding Config.in
symbol called BR2_PACKAGE_FOO
- Host packages are named "host-foo" and generally do not have a
corresponding Config.in symbol.
Therefore:
- A host build-time dependency is added by doing <pkg>_DEPENDENCIES =
host-foo
- Target build-time dependency is added by doing <pkg>_DEPENDENCIES =
foo *AND* selecting BR2_PACKAGE_FOO
- Target run-time dependency is added by selecting BR2_PACKAGE_FOO
My understanding regarding numpy is that it is a:
- Target run-time dependency
- Host build-time dependency
> ifeq ($(BR2_PACKAGE_GNURADIO_PYTHON),y)
> -GNURADIO_DEPENDENCIES += python3
> +GNURADIO_DEPENDENCIES += python3 python-pybind \
This python-pybind looks weird. Why would the *target* package be
needed at build-time? Are you sure it's not host-python-pybind that is
needed? I don't see how python-pybind can be used at build time, since
it's a target package.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-23 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 12:51 [Buildroot] [PATCH v3] package/gnuradio: bump version to 3.10.4.0 Gwenhael Goavec-Merou
2022-09-23 21:51 ` Thomas Petazzoni [this message]
2022-09-27 8:52 ` Gwenhael Goavec-Merou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923235149.5b312376@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=gwenhael.goavec-merou@trabucayre.com \
--cc=gwenj@trabucayre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox