Re: [Buildroot] [PATCH 00/13] package/nodejs: rework cross-building

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Alexandru Ardelean <ardeleanalex@gmail.com>
Cc: fontaine.fabrice@gmail.com, aduskett@gmail.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 00/13] package/nodejs: rework cross-building
Date: Sun, 25 Sep 2022 10:27:14 +0200	[thread overview]
Message-ID: <20220925102714.163869b8@windsurf> (raw)
In-Reply-To: <20220809075704.86472-1-ardeleanalex@gmail.com>

Hello Alexandru,

On Tue,  9 Aug 2022 10:56:51 +0300
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:

> Alexandru Ardelean (13):
>   package/libuv: add host-build
>   package/nghttp2: add host-build
>   nodejs: remove v8-qemu-wrapper stuff
>   nodejs: fix 'Duplicate v8 target errors when cross-compiling' error
>   package/nodejs: add host-{c-ares,libuv,nghttp2} to deps
>   package/nodejs: provide {CC,CXX,CFLAGS,CXXFLAGS,LDFLAGS}_host env vars
>     to target-build
>   package/nodejs: don't install nodejs host-tools
>   package/nodejs: rename LDFLAGS.host -> LDFLAGS opt
>   package/nodejs: impose dep on ia32 libs/compiler if target arch not 64
>     bits
>   package/nodejs: add host-zlib depedency to target package
>   package/nodejs: fix ARM build with VFP3 instruction
>   package/nodejs: add a hack to cross-compile 32-bit targets on x64
>     hosts
>   package/nodejs: build host-nodejs only if we're installing modules
>     with NPM

So I finally took some time to look into this, and managed to get
NodeJS to build, but keeping the Qemu logic. Here is what I have pushed
to the Buildroot Git repo:

  https://gitlab.com/buildroot.org/buildroot/-/commit/f85e2cfc6e587d50b86f49b28469eae58a2ea2c7

  Just renumbering an existing patch

  https://gitlab.com/buildroot.org/buildroot/-/commit/5708c5b04f09f49a99c2c9d7a1894d24bce6a3e7

  Your patch to fix the duplicate v8 target error, just slightly
  improved by me.

  https://gitlab.com/buildroot.org/buildroot/-/commit/cf0ddc89705af989393b1601bbf57d567a9a1b13

  A patch from me which is fixing the issue with the Qemu approach.
  Basically, since the bump from 14.x to 16.x, one call to a tool that
  should be run under Qemu was not done through the wrapper, causing
  the build failure. With this fixed, NodeJS builds just fine with the
  current approach.

  Even though I dislike having to build Qemu, it is what OpenEmbedded
  is also doing to build NodeJS, and we don't have much choice as we
  need those tools to have the same bitness as the target.

  https://gitlab.com/buildroot.org/buildroot/-/commit/ec5589611ad79664bc5bf238cc786a65458f3c93

  Your patch to not install the extra tools of host-nodejs, as they are
  no longer needed: we use the target tools, and run them under Qemu.

  https://gitlab.com/buildroot.org/buildroot/-/commit/1facb09b94bf806b301868539185c0ff9ddffee2

  Your patch to no longer build host-nodejs as a dependency of nodejs,
  unless some extra NPM modules need to be installed, in which case npm
  is needed.

So here, NodeJS now builds/runs fine. Could you check on your side if
that also solves your problems?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot