Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Thomas Claveirole <thomas.claveirole@green-communications.fr>
Cc: Daniel Price <daniel.price@gmail.com>,
	Martin Bark <martin@barkynet.com>,
	Johan Oudinet <johan.oudinet@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/nodejs: introduce BR2_PACKAGE_HOST_NODEJS_COREPACK
Date: Sun, 25 Sep 2022 21:47:00 +0200	[thread overview]
Message-ID: <20220925214700.5e222e95@windsurf> (raw)
In-Reply-To: <20220913174039.182887-2-thomas.claveirole@green-communications.fr>

On Tue, 13 Sep 2022 19:40:38 +0200
Thomas Claveirole <thomas.claveirole@green-communications.fr> wrote:

> +ifeq ($(BR2_PACKAGE_HOST_NODEJS_COREPACK),y)
> +define HOST_NODEJS_ENABLE_COREPACK
> +	$(COREPACK) enable
> +endef
> +endif

Could you explain in a bit more details what this "corepack enable"
actually does?

Indeed, I was documenting myself a little bit on pnpm, and
https://pnpm.io/installation says that "corepack enable" will
"automatically install pnpm on your system".

So is "corepack enable" download extra stuff? If so, it's not great at
all to have this executed as part of the installation step of a
package. Or is pnpm shipped as part of nodejs, and that simply installs
it?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-09-25 19:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13 17:40 [Buildroot] [PATCH 0/2] Update host-nodejs and build vuejs from source Thomas Claveirole
2022-09-13 17:40 ` [Buildroot] [PATCH 1/2] package/nodejs: introduce BR2_PACKAGE_HOST_NODEJS_COREPACK Thomas Claveirole
2022-09-25 19:47   ` Thomas Petazzoni [this message]
2022-09-25 19:53     ` Thomas Petazzoni
2022-09-26  9:04       ` Thomas Claveirole
2022-09-26 10:01         ` Thomas Petazzoni
2022-09-26 10:17           ` Johan Oudinet
2022-09-26 10:24             ` Thomas Petazzoni
2023-04-16 19:48   ` Yann E. MORIN
2022-09-13 17:40 ` [Buildroot] [PATCH 2/2] package/vuejs: bump to version 3.2.39 Thomas Claveirole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220925214700.5e222e95@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=daniel.price@gmail.com \
    --cc=johan.oudinet@gmail.com \
    --cc=martin@barkynet.com \
    --cc=thomas.claveirole@green-communications.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox