Re: [Buildroot] [PATCH] package/mdio-tools: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Robert, All,

On 2022-09-28 21:23 +0200, Robert Marko spake thusly:
> mdio-tools are kernel module and accompanying tools for low-level
> debugging of devices attached on MDIO bus like PHY-s, switches etc.
> 
> Userspace tools provide C22 or C45 reads and writes, benchmarking
> and even dedicated Marvell Link Street tools via the included
> kernel module.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/mdio-tools/mdio-tools.mk b/package/mdio-tools/mdio-tools.mk
> new file mode 100644
> index 0000000000..e4ea6f8224
> --- /dev/null
> +++ b/package/mdio-tools/mdio-tools.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# mdio-tools
> +#
> +################################################################################
> +
> +MDIO_TOOLS_VERSION = 1.2.0
> +MDIO_TOOLS_SITE = https://github.com/wkz/mdio-tools/releases/download/$(MDIO_TOOLS_VERSION)
> +MDIO_TOOLS_LICENSE = GPL-2.0-only

We do not strictly follow the SPDX nomenclature (because we somewhat
predate it), so for consistency, this should be just 'GPL-2.0'.

> +MDIO_TOOLS_LICENSE_FILES = COPYING
> +MDIO_TOOLS_DEPENDENCIES = libmnl

mdio-tools uses pkg-config to look for libmnl, so you also need to add
host-pkgconf to the _DEPENDENCES.

> +MDIO_TOOLS_MODULE_SUBDIRS = kernel

I did not have a thorough look, but doesn't mdio-tools need some kernel
options to always be enabled? IF so, you can do so with:

    define MDIO_TOOLS_LINUX_CONFIG_FIXUPS
        $(call KCONFIG_ENABLE_OPT,CONFIG_MDIO)
    endef

(given the package name, it should at least require that, I'd guess, but
adapt as needed.)

If there had been only the license and host-pkgconf issues, I'd have
fixed those when applying. But the kernel options are a bit more
involved, and requie someone who actually knows and uses mdio-tools, to
come up with the required options. Can you look into that, please?

Regards,
Yann E. MORIN.

> +$(eval $(kernel-module))
> +$(eval $(autotools-package))
> -- 
> 2.37.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot