Re: [Buildroot] [PATCH 1/1] package/glibc: fix fsconfig_command redeclaration bug

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: buildroot@athaariq.my.id
Cc: Romain Naour <romain.naour@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/glibc: fix fsconfig_command redeclaration bug
Date: Sun, 2 Oct 2022 09:40:28 +0200	[thread overview]
Message-ID: <20221002074028.GB30794@scaer> (raw)
In-Reply-To: <8c42038a335a0122dee3365ce1940920@athaariq.my.id>

Athaariq, Al,

On 2022-10-02 03:33 +0000, buildroot@athaariq.my.id spake thusly:
> >This issue is really weird, because the glibc commit we are using is
> >supposed to contain the related fixes
> Pardon me for being so weird.

You are not being weird, no worries.

> What I'm trying to fix is this error:
> error: multiple definition of ‘enum fsconfig_command’

Yes, we are aware of that issue.

> I did spent entire morning last two days ago and I figured out that no
> matter how do I detect linux/mount.h presence in "sys/mount.h", **enum
> fsconfig_command** still in clash between linux-headers and glibc. However,
> the problem only exist in glibc v2.36 whereas no effect when I changed linux
> version. Thus, linux-headers seems to be declared after glibc.

When you change the linux headers version in Buildroot, you need to
restart from a clean state, i.e. run "make clean" before resuming the
build, see the full explanations in the manual:
    https://buildroot.org/downloads/manual/manual.html#full-rebuild

> >How is this a buildroot-specific bug? Can you elaborate on that part? If
> >it is really a buildroot-related bug, then we want to understand it, and
> >fix it, not work around it.
> 
> Because it successfully compiled in Gentoo but failed when compile Buildroot
> for Raspberry Pi 4 and Raspberry Pi 3, with default configuration. The
> reason why I asked "Is this possible on Buildroot?" is to give you two
> options:
> 1. If possible, let's make sure linux-headers installed before glibc
> 2. If not, let's workaround for a while until there's a revelation from
> upstream
> 
> >This is exactly what we are doing already, and for as long as Buildroot
> >has supported building a glibc-ased toolchain, as the kernel headers are
> >required to build glibc; see package/glibc/glibc.mk@28:
> 
> Well that's interesting. Wonder why that enum redeclaration error exist and
> my last patch actually works.

Yes, we really need to understand why it is broken in the first place,
to evaluate whether your patch is correct, or whether we should change
the way we do things in Buildroot. Hint: I think we do something in
Buildroot that is wrong (or has become wrong as time passed), but we
could not pinpoint it yet...

> >To be noted, and as Thomas noticed, OpenEmbeded is also using a glibc
> >2.36 commit, and even one older than ours, but they do not seem to have
> >issues.
> 
> Honestly, I only tested it on my Raspberry Pi 4 and my friend's Raspberry Pi
> 3 with latest origin/master and default configuration. Yesterday, I realized
> that all raspberry boards are symlinked into one directory after checked
> autobuild. Perhaps, board specific issue? If correct, I'm going to patch the
> custom kernel instead, plus bump it.

It is not specific to the raspberrypi, we have tons of builds failing on
various architectures:
    http://autobuild.buildroot.net/?reason=glibc-2.36-%

> I also noticed Raspberry Pi boards are marked ORPH at autobuild. Is that
> means orphan? If yes, I would gladly contribute as board maintainer. Thank
> you for your cooperation.

Weird, as we already have two persons registered for the rpi series:

    $ ./utils/get-developers -f configs/raspberrypi* board/raspberrypi/
    Julien Grossholtz <julien.grossholtz@openest.io>
    Martin Bark <martin@barkynet.com>

But if you want to be added to that list, do not hesitate to send a
patch against the DEVELOPERS file to add yourself.

> NB: My nickname is Eric

Erics are everywhere! :-)

Is that what you want to be adressed by, or should we go with Athaariq?

Regards,
Yann E. MORIN.

> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot