Re: [Buildroot] [PATCH 3/4] package/mender-artifact: bump version to 3.9.0

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed,  5 Oct 2022 14:21:49 -0700
Adam Duskett <aduskett@gmail.com> wrote:

> mender-artifact now requires OpenSSL, and is incompatible with OpenSSL3.
> As such, the host-pkgconf and host-libopenssl packages are now dependencies to
> prevent linking errors against OpenSSL3 on newer distributions such as
> Fedora 35.

Even if mender-artifact was compatible with OpenSSL3, it would be a bug
to rely on the system-provided OpenSSL library.

> +# Mender-artifact requires OpenSSL, and is not yet compatible with OpenSSL3.
> +# Mender-artifact also uses pkgconf to find the OpenSSL library.
> +# Use host-pkgconf to force mender-artifact to use Buildroots host-openssl, as
> +# newer distributions, such as Fedora, are starting to use OpenSSL3.
> +HOST_MENDER_ARTIFACT_GO_ENV = \
> +	GOFLAGS="-mod=vendor" \
> +	PKG_CONFIG_PATH="$(HOST_DIR)/lib/pkgconfig"

Why is -mod=vendor needed here?

Also for pkg-config, I would prefer if we were to use the same
variables as defined in HOST_MAKE_ENV (in package/Makefile.in), i.e:

HOST_MAKE_ENV = \
        PATH=$(BR_PATH) \
        PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
        PKG_CONFIG_SYSROOT_DIR="/" \
        PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 \
        PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 \
        PKG_CONFIG_LIBDIR="$(HOST_DIR)/lib/pkgconfig:$(HOST_DIR)/share/pkgconfig"

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot