From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/Makefile.in: set .NOTPARALLEL for MAKE1
Date: Sun, 16 Oct 2022 18:35:43 +0200 [thread overview]
Message-ID: <20221016163543.GM2503@scaer> (raw)
In-Reply-To: <20221016162654.GL2503@scaer>
On 2022-10-16 18:26 +0200, Yann E. MORIN spake thusly:
> James, All,
>
> On 2022-10-14 18:56 -0600, James Hilliard spake thusly:
> > Make 4.4 introduces a shuffle mode which randomizes prerequisites
> > in order to better flush out issues with parallel builds, as this
> > mode randomizes prerequisites even when using -j1 builds we must
> > instead explicitely mark parallel incompatible builds using the
> > .NOTPARALLEL special target which disables prerequisites
> > randomization when running in shuffle mode.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > package/Makefile.in | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/Makefile.in b/package/Makefile.in
> > index 43d214bcbe..2327849a1f 100644
> > --- a/package/Makefile.in
> > +++ b/package/Makefile.in
> > @@ -17,7 +17,7 @@ else
> > PARALLEL_JOBS := $(BR2_JLEVEL)
> > endif
> >
> > -MAKE1 := $(HOSTMAKE) -j1
> > +MAKE1 := $(HOSTMAKE) --eval .NOTPARALLEL:
>
> Packages that do not build in parallel do not because their rules assume
> the ordering is kept.
>
> I don't see how replacing -j1 with --eval .NOTPARALLEL: would cause the
> ordering to be restored.
Ah, it's in the --shuffle documentation, not in the .NOTPARALLEL one (and
reading .texi source is not my main ability).
Still, I think my proposal is better, because it is more explicit.
Regards,
Yann E. MORIN.
> Instead, I would have expected we do something like:
>
> # Only build one job at a time, *and* to not randomise goals and
> # prerequisites ordering in make 4.4+
> MAKE1 := $(HOSTMAKE) -j1 $(if $(findstring --shuffle,$(MAKEFLAGS)),--shuffle=none)
>
> Regards,
> Yann E. MORIN.
>
> > override MAKE = $(HOSTMAKE) \
> > $(if $(findstring j,$(filter-out --%,$(MAKEFLAGS))),,-j$(PARALLEL_JOBS))
> >
> > --
> > 2.34.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-16 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 0:56 [Buildroot] [PATCH 1/1] package/Makefile.in: set .NOTPARALLEL for MAKE1 James Hilliard
2022-10-16 16:26 ` Yann E. MORIN
2022-10-16 16:35 ` Yann E. MORIN [this message]
2022-10-16 16:53 ` James Hilliard
2022-10-16 18:46 ` Yann E. MORIN
2022-10-16 19:18 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221016163543.GM2503@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox