From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Christian Stewart <christian@paral.in>
Cc: Geoff Levand <geoff@infradead.org>,
Anisse Astier <anisse@astier.eu>,
Thomas Perale <thomas.perale@mind.be>,
Angelo Compagnucci <angelo.compagnucci@gmail.com>,
Marcin Niestroj <m.niestroj@grinn-global.com>,
Buildroot Mailing List <buildroot@buildroot.org>,
Romain Naour <romain.naour@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
Thomas Perale <thomas.perale@essensium.com>
Subject: Re: [Buildroot] [PATCH 3/4] package/go-bin: new package
Date: Tue, 18 Oct 2022 08:36:32 +0200 [thread overview]
Message-ID: <20221018083632.6f336ec6@windsurf> (raw)
In-Reply-To: <CA+h8R2pNnYsj9Yz0Do_UKQz+XWiz4LTxPrLz_aQgGEg1LsZsOg@mail.gmail.com>
On Mon, 17 Oct 2022 09:13:54 -0700
Christian Stewart <christian@paral.in> wrote:
> Instead of adding new packages...
>
> Continue using "host-go" and add parameters under a menu config for it.
> Then you can simply use a single variable - GO_VERSION - rather than 2 new
> packages.
>
> I'm happy to send a prototype of this if you need.
I also thought of doing this for the NodeJS package, instead of
separating host-nodejs-bin and host-nodejs-src. I went for the
virtual-package + 2 providers solution as this is what we had done with
Rust.
The main advantage I see with the single package solution is that the
version of NodeJS would be located at only one place. Although this
could also be solved by:
package/
nodejs/
nodejs.mk <= contains the version
nodejs/ <= virtual package
nodejs-bin/ <= pre-compiled provider
nodejs-src/ <= source-based provider
In my proposal I solved this duplicated version by simply having a
comment above the <pkg>_VERSION field to remind people that the other
package supporting NodeJS should be bumped at the same time.
The advantage of the 2 packages solution is obviously that each package
is simpler.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-18 6:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221017143125.41622-1-thomas.perale@mind.be>
[not found] ` <20221017143125.41622-3-thomas.perale@mind.be>
2022-10-17 16:10 ` [Buildroot] [PATCH 2/4] package/pkg-golang: set dependencies to host-goc Christian Stewart via buildroot
[not found] ` <20221017143125.41622-4-thomas.perale@mind.be>
2022-10-17 16:13 ` [Buildroot] [PATCH 3/4] package/go-bin: new package Christian Stewart via buildroot
2022-10-18 6:36 ` Thomas Petazzoni via buildroot [this message]
[not found] <20221017142849.41399-1-thomas.perale@mind.be>
[not found] ` <20221017142849.41399-4-thomas.perale@mind.be>
2022-10-17 16:05 ` Christian Stewart via buildroot
2022-10-17 18:03 ` Yann E. MORIN
2022-10-17 18:42 ` Thomas Petazzoni via buildroot
2022-10-17 18:52 ` Christian Stewart via buildroot
2022-10-17 15:17 [Buildroot] [PATCH 0/4] Add support for using a pre-compiled Go compiler Thomas Perale via buildroot
2022-10-17 15:17 ` [Buildroot] [PATCH 3/4] package/go-bin: new package Thomas Perale via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018083632.6f336ec6@windsurf \
--to=buildroot@buildroot.org \
--cc=angelo.compagnucci@gmail.com \
--cc=anisse@astier.eu \
--cc=christian@paral.in \
--cc=festevam@gmail.com \
--cc=geoff@infradead.org \
--cc=m.niestroj@grinn-global.com \
--cc=romain.naour@gmail.com \
--cc=thomas.perale@essensium.com \
--cc=thomas.perale@mind.be \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox