From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/rtl8188eu: remove wrong description in Config.in
Date: Wed, 19 Oct 2022 09:15:12 +0200 [thread overview]
Message-ID: <20221019091512.77a48aa8@booty> (raw)
In-Reply-To: <20221018131506.123350-1-giulio.benetti@benettiengineering.com>
Hi Giulio,
On Tue, 18 Oct 2022 15:15:06 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> This rtl8188eu driver is not the same as the one in mainline Linux that
> still has pending work to be done that in this driver is done, check:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/r8188eu/TODO
> specifically:
> * Switch to use LIB80211.
> * Switch to use MAC80211.
> * Switch to use CFG80211.
> So let's remove the description that is not valid anymore.
A lot of this text would be useful in the help text below. The help
text is visible in any moment in later releases, the commit log needs
to be searched.
> Suggested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/rtl8188eu/Config.in | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/package/rtl8188eu/Config.in b/package/rtl8188eu/Config.in
> index 76d9085297..8d68d104c8 100644
> --- a/package/rtl8188eu/Config.in
> +++ b/package/rtl8188eu/Config.in
> @@ -4,9 +4,6 @@ config BR2_PACKAGE_RTL8188EU
> depends on BR2_LINUX_KERNEL
> help
> A standalone driver for the RTL8188EU USB Wi-Fi adapter.
> - This is needed only for Linux kernels before 3.12.
> - Since 3.12, there is a (staging) driver in mainline, with a
> - similar codebase.
For the above reasons, I'd add here:
This rtl8188eu driver is not the same as the one in mainline Linux that
still has pending work to be done that in this driver is done, check:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/r8188eu/TODO
I'd not add the todo list, as it will (hopefully) change in the future
in the kernel and we don't want to keep updating our own copy.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-19 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 13:15 [Buildroot] [PATCH] package/rtl8188eu: remove wrong description in Config.in Giulio Benetti
2022-10-19 7:15 ` Luca Ceresoli via buildroot [this message]
2022-10-19 13:49 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019091512.77a48aa8@booty \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=luca.ceresoli@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox