Re: [Buildroot] [PATCH] package/musl: fixup the dynamic loader symlink

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Yann,

On Wed, 26 Oct 2022 15:31:22 +0200
<yann.morin@orange.com> wrote:

> What about external toolchains?

That's a very good question, which I had not looked into, so I did some
research.

External toolchains are not affected because when we copy the sysroot
from the toolchain into STAGING_DIR, we do this:

        for link in $$(find $(STAGING_DIR) -type l); do \
                target=$$(readlink $${link}) ; \
                if [ "$${target}" == "$${target$(SHARP_SIGN)/}" ] ; then \
                        continue ; \
                fi ; \
                relpath="$(call relpath_prefix,$${target$(SHARP_SIGN)/})" ; \
                echo "Fixing symlink $${link} from $${target} to $${relpath}$${target$(SHARP_SIGN)/}" ; \
                ln -sf $${relpath}$${target$(SHARP_SIGN)/} $${link} ; \
        done ; \

(from toolchain/helpers.mk:copy_toolchain_sysroot)

This causes this to happen:

>>> toolchain-external-bootlin 2021.11-1 Copying external toolchain sysroot to staging...
Fixing symlink /home/thomas/projets/buildroot/output/host/x86_64-buildroot-linux-musl/sysroot/lib/ld-musl-x86_64.so.1 from /lib/libc.so to ../lib/libc.so

So in the external toolchain, even if the symlink is broken, it gets
fixed when we import the toolchain into STAGING_DIR.

(Note: the external toolchain used here is a Bootlin toolchain,
produced by Buildroot, but without the musl.mk fix, so it does have the
bogus ld-musl-x86-64.so.1 -> /lib/libc.so link, but that gets fixed
when we import the toolchain, as described above)

Does that this seem like a good enough answer for the external
toolchain case? If so, I can submit a v2 with an amended commit log.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot