Re: [Buildroot] [PATCH 4/4] package/kmemd: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Thu, 20 Oct 2022 16:14:12 +0200
Tobias Waldekranz <tobias@waldekranz.com> wrote:

> kmemd let's you inspect a live Linux kernel's memory using GDB.
> 
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>

I have applied a patch, with a few small changes.

> ---
>  package/Config.in        |  1 +
>  package/kmemd/Config.in  | 11 +++++++++++
>  package/kmemd/kmemd.hash |  5 +++++
>  package/kmemd/kmemd.mk   | 20 ++++++++++++++++++++
>  4 files changed, 37 insertions(+)

I added an entry in the DEVELOPERS file for this package, so that we
know you are the contact. You will receive e-mails if there are build
failures or CVEs affecting this package, and when new releases are made
upstream (even though I suppose you are the upstream maintainer, so you
should already know!)

> diff --git a/package/kmemd/Config.in b/package/kmemd/Config.in
> new file mode 100644
> index 0000000000..2190488b0f
> --- /dev/null
> +++ b/package/kmemd/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_KMEMD
> +	bool "kmemd"
> +	depends on BR2_PACKAGE_LIBBPF_SUPPORTED

Changed to repeat the dependencies of libbpf.

> +	select BR2_PACKAGE_LIBBPF
> +	help
> +	  Explore a live Linux kernel's memory using GDB
> +
> +	  https://github.com/wkz/kmemd
> +
> +comment "kmemd needs libbpf"
> +	depends on !BR2_PACKAGE_LIBBPF_SUPPORTED

This comment was not correct: you are selecting libbpf, so you don't
need to say that you need it. Instead, I've added our usual comment,
which corresponds to the dependencies inherited from libbpf.

> diff --git a/package/kmemd/kmemd.hash b/package/kmemd/kmemd.hash
> new file mode 100644
> index 0000000000..60b8589dd2
> --- /dev/null
> +++ b/package/kmemd/kmemd.hash
> @@ -0,0 +1,5 @@
> +# Locally calculated
> +md5  9954bf82279eeb0da016654689f69ac2  kmemd-1.0.0.tar.gz
> +sha1  3ae3bdceb70d674f41f56cd489c7497944b9b0f0  kmemd-1.0.0.tar.gz
> +sha256  519ac3cdd367acee5090eec3b7e08400724f9b84486b191f3af534bd7cffca70  kmemd-1.0.0.tar.gz

When we have a sha256, md5/sha1 hashes are not needed, so I dropped them.

Applied with those changes, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot