Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nasser Afshin <afshin.nasser@gmail.com>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] python-pycrate: new package
Date: Sat, 29 Oct 2022 11:32:29 +0330	[thread overview]
Message-ID: <20221029080229.GA24217@smart-All-Series> (raw)
In-Reply-To: <CAGm1_ktx6UuANUZ=Eqbh_wr7JrJNaHz=ou9zg9mSvGP+ivnzmA@mail.gmail.com>

Hi Yegor,

On Wed, Oct 26, 2022 at 08:21:30PM +0200, Yegor Yefremov wrote:
> Hi Nasser,
> 
> On Wed, Oct 26, 2022 at 12:23 PM Nasser Afshin <afshin.nasser@gmail.com> wrote:
> >
> > Hi Yegor,
> >
> > Thankyou for taking time to review my patch.
> >
> > On Tue, Oct 25, 2022 at 10:33:19AM +0200, Yegor Yefremov wrote:
> > > Hi Nasser,
> > >
> > > On Tue, Oct 25, 2022 at 8:55 AM Nasser Afshin <afshin.nasser@gmail.com> wrote:
> > > >
> > > > Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com>
> > > > ---
> > > >  package/Config.in                          |  1 +
> > > >  package/python-pycrate/Config.in           |  8 ++++++++
> > > >  package/python-pycrate/python-pycrate.hash |  4 ++++
> > > >  package/python-pycrate/python-pycrate.mk   | 13 +++++++++++++
> > >
> > > An entry to the DEVELOPERS file is missing.
> >
> > May you help me to whome this entry should refer?
> 
> You should add yourself as a "maintainer" of the package you add. Just
> look at other entries.
> 
I have added myself as a maintainer of this package. Thankyou.

> >
> > >
> > > >  4 files changed, 26 insertions(+)
> > > >  create mode 100644 package/python-pycrate/Config.in
> > > >  create mode 100644 package/python-pycrate/python-pycrate.hash
> > > >  create mode 100644 package/python-pycrate/python-pycrate.mk
> > > >
> > > > diff --git a/package/Config.in b/package/Config.in
> > > > index 56b1a08d8b..2443b7bb27 100644
> > > > --- a/package/Config.in
> > > > +++ b/package/Config.in
> > > > @@ -951,6 +951,7 @@ menu "External python modules"
> > > >         source "package/python-pyasn1-modules/Config.in"
> > > >         source "package/python-pycli/Config.in"
> > > >         source "package/python-pycparser/Config.in"
> > > > +       source "package/python-pycrate/Config.in"
> > > >         source "package/python-pycrypto/Config.in"
> > > >         source "package/python-pycryptodomex/Config.in"
> > > >         source "package/python-pydal/Config.in"
> > > > diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in
> > > > new file mode 100644
> > > > index 0000000000..9e2123d4dd
> > > > --- /dev/null
> > > > +++ b/package/python-pycrate/Config.in
> > > > @@ -0,0 +1,8 @@
> > > > +config BR2_PACKAGE_PYTHON_PYCRATE
> > > > +       bool "python-pycrate"
> > > > +       help
> > > > +        It provides basically a runtime for encoding and decoding data structures,
> > > > +        including CSN.1 and ASN.1. Additionally, it features a 3G and LTE mobile core
> > > > +        network.
> > > > +
> > > > +        https://github.com/P1sec/pycrate/
> > > > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash
> > > > new file mode 100644
> > > > index 0000000000..24aa51d8e4
> > > > --- /dev/null
> > > > +++ b/package/python-pycrate/python-pycrate.hash
> > > > @@ -0,0 +1,4 @@
> > > > +# md5 from https://pypi.python.org/pypi/pycrate/json
> > > > +md5    075622d5d573274cd4dbfe268ca52f7f  pycrate-0.5.5.tar.gz
> > > > +# Locally computed
> > > > +sha256  59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af  pycrate-0.5.5.tar.gz
> > > > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk
> > > > new file mode 100644
> > > > index 0000000000..41ce6c18f2
> > > > --- /dev/null
> > > > +++ b/package/python-pycrate/python-pycrate.mk
> > > > @@ -0,0 +1,13 @@
> > > > +################################################################################
> > > > +#
> > > > +# python-pycrate
> > > > +#
> > > > +################################################################################
> > > > +
> > > > +PYTHON_PYCRATE_VERSION = 0.5.5
> > > > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz
> > > > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df
> > > > +PYTHON_PYCRATE_SETUP_TYPE = distutils
> > >
> > > SETUP_TYPE is setuptools.
> > >
> > > Have you tried this command?
> > >
> > > ./utils/scanpypi pycrate
> > >
> > > It will do almost everything you need. The thing that is missing is
> > > licensing info because there is no license file in the source archive.
> >
> > Thankyou for pointing this out. Now I send a new version, using this
> > command and also adding licensing info.
> > >
> > > Best regards,
> > > Yegor
> > >
> > > > +PYTHON_PYCRATE_LICENSE = LGPL-2.1-or-later
> > > > +
> > > > +$(eval $(python-package))
> > > > --
> > > > 2.17.1
> > > >
> >
> > This is the second version of my patch.
> >
> > From 979beabd86f1c15d159e37136bc9591fb39b844e Mon Sep 17 00:00:00 2001
> > From: Nasser Afshin <Afshin.Nasser@gmail.com>
> > Date: Tue, 25 Oct 2022 16:06:53 +0330
> > Subject: [PATCH v2] python-pycrate: new package
> >
> > Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com>
> > ---
> > v1 -> v2: Added licence file and its checksum
> >                  Used ./utils/scanpypi pycrate tool to be consistent with
> >                  others
> >
> >  package/Config.in                          |  1 +
> >  package/python-pycrate/Config.in           |  6 ++++++
> >  package/python-pycrate/python-pycrate.hash |  6 ++++++
> >  package/python-pycrate/python-pycrate.mk   | 14 ++++++++++++++
> >  4 files changed, 27 insertions(+)
> >  create mode 100644 package/python-pycrate/Config.in
> >  create mode 100644 package/python-pycrate/python-pycrate.hash
> >  create mode 100644 package/python-pycrate/python-pycrate.mk
> >
> > diff --git a/package/Config.in b/package/Config.in
> > index e3a34d6e97..a6fcc72cc8 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -1168,6 +1168,7 @@ menu "External python modules"
> >         source "package/python-pycairo/Config.in"
> >         source "package/python-pycares/Config.in"
> >         source "package/python-pycparser/Config.in"
> > +       source "package/python-pycrate/Config.in"
> >         source "package/python-pycryptodomex/Config.in"
> >         source "package/python-pycups/Config.in"
> >         source "package/python-pydal/Config.in"
> > diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in
> > new file mode 100644
> > index 0000000000..193a973f7e
> > --- /dev/null
> > +++ b/package/python-pycrate/Config.in
> > @@ -0,0 +1,6 @@
> > +config BR2_PACKAGE_PYTHON_PYCRATE
> > +       bool "python-pycrate"
> > +       help
> > +         A software suite to handle various data formats.
> > +
> > +         https://github.com/P1sec/pycrate/
> > diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash
> > new file mode 100644
> > index 0000000000..8ad33370b4
> > --- /dev/null
> > +++ b/package/python-pycrate/python-pycrate.hash
> > @@ -0,0 +1,6 @@
> > +# md5, sha256 from https://pypi.org/pypi/pycrate/json
> > +md5  075622d5d573274cd4dbfe268ca52f7f  pycrate-0.5.5.tar.gz
> > +sha256  59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af  pycrate-0.5.5.tar.gz
> > +# Locally computed
> > +sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  license.txt
> > +
> > diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk
> > new file mode 100644
> > index 0000000000..c0da152656
> > --- /dev/null
> > +++ b/package/python-pycrate/python-pycrate.mk
> > @@ -0,0 +1,14 @@
> > +################################################################################
> > +#
> > +# python-pycrate
> > +#
> > +################################################################################
> > +
> > +PYTHON_PYCRATE_VERSION = 0.5.5
> > +PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz
> > +PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df
> > +PYTHON_PYCRATE_SETUP_TYPE = setuptools
> > +PYTHON_PYCRATE_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/P1sec/pycrate/master/license.txt
> > +PYTHON_PYCRATE_LICENSE = LGPL-2.1+
> > +
> > +$(eval $(python-package))
> 
> The patch looks good now. Thanks.
> 
> Best regards,
> Yegor

This is the third version of the patch:

From de6e28885836a6d9a5347a083a68055098508583 Mon Sep 17 00:00:00 2001
From: Nasser Afshin <Afshin.Nasser@gmail.com>
Date: Tue, 25 Oct 2022 16:06:53 +0330
Subject: [PATCH v3] python-pycrate: new package

Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com>
---
v1 -> v2: Added licence file and its checksum
		Used ./utils/scanpypi pycrate tool to be consistent with
		others
v2 -> v3: Added myself as the maintainer of this package

 DEVELOPERS                                 |  3 +++
 package/Config.in                          |  1 +
 package/python-pycrate/Config.in           |  6 ++++++
 package/python-pycrate/python-pycrate.hash |  6 ++++++
 package/python-pycrate/python-pycrate.mk   | 14 ++++++++++++++
 5 files changed, 30 insertions(+)
 create mode 100644 package/python-pycrate/Config.in
 create mode 100644 package/python-pycrate/python-pycrate.hash
 create mode 100644 package/python-pycrate/python-pycrate.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 6e0b765ba1..a1b48fd45c 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2157,6 +2157,9 @@ N:	Murat Demirten <mdemirten@yh.com.tr>
 F:	package/jpeg-turbo/
 F:	package/libgeotiff/
 
+N:	Nasser Afshin <afshin.nasser@gmail.com>
+F:	package/python-pycrate/
+
 N:	Nathaniel Roach <nroach44@gmail.com>
 F:	package/bandwidthd/
 F:	package/libgudev/
diff --git a/package/Config.in b/package/Config.in
index e3a34d6e97..a6fcc72cc8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1168,6 +1168,7 @@ menu "External python modules"
 	source "package/python-pycairo/Config.in"
 	source "package/python-pycares/Config.in"
 	source "package/python-pycparser/Config.in"
+	source "package/python-pycrate/Config.in"
 	source "package/python-pycryptodomex/Config.in"
 	source "package/python-pycups/Config.in"
 	source "package/python-pydal/Config.in"
diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in
new file mode 100644
index 0000000000..193a973f7e
--- /dev/null
+++ b/package/python-pycrate/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PYTHON_PYCRATE
+	bool "python-pycrate"
+	help
+	  A software suite to handle various data formats.
+
+	  https://github.com/P1sec/pycrate/
diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash
new file mode 100644
index 0000000000..8ad33370b4
--- /dev/null
+++ b/package/python-pycrate/python-pycrate.hash
@@ -0,0 +1,6 @@
+# md5, sha256 from https://pypi.org/pypi/pycrate/json
+md5  075622d5d573274cd4dbfe268ca52f7f  pycrate-0.5.5.tar.gz
+sha256  59f09331890a389a6b98412f19f4fb021c5a75a35ab07bf5ba0d1e299a0967af  pycrate-0.5.5.tar.gz
+# Locally computed
+sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  license.txt
+
diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk
new file mode 100644
index 0000000000..c0da152656
--- /dev/null
+++ b/package/python-pycrate/python-pycrate.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-pycrate
+#
+################################################################################
+
+PYTHON_PYCRATE_VERSION = 0.5.5
+PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz
+PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/25/8f/b3d7e0b541aa04b2f0f7aa694a6946b572bfa2e2627cf1f12b5416d633df
+PYTHON_PYCRATE_SETUP_TYPE = setuptools
+PYTHON_PYCRATE_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/P1sec/pycrate/master/license.txt
+PYTHON_PYCRATE_LICENSE = LGPL-2.1+
+
+$(eval $(python-package))
-- 
2.17.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-10-29  8:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25  6:55 [Buildroot] [PATCH] python-pycrate: new package Nasser Afshin
2022-10-25  8:33 ` Yegor Yefremov via buildroot
     [not found]   ` <20221026102255.GA602@smart-All-Series>
     [not found]     ` <CAGm1_ktx6UuANUZ=Eqbh_wr7JrJNaHz=ou9zg9mSvGP+ivnzmA@mail.gmail.com>
2022-10-29  8:02       ` Nasser Afshin [this message]
2022-10-30  9:11         ` Yegor Yefremov via buildroot
2022-11-08  8:45           ` [Buildroot] [PATCH v3 RESEND] " Nasser Afshin
2023-02-17 14:36             ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221029080229.GA24217@smart-All-Series \
    --to=afshin.nasser@gmail.com \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox