From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: Charles Hardin <ckhardin@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/4] package/alsa-lib: disable topology modules for static builds
Date: Sun, 30 Oct 2022 15:00:35 +0100 [thread overview]
Message-ID: <20221030150035.48cf618b@windsurf> (raw)
In-Reply-To: <20221028191526.122405-1-bernd.kuhls@t-online.de>
Hello,
On Fri, 28 Oct 2022 21:15:23 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> With this fix to alsa-lib we can remove a patch from alsa-utils which
> fixed its static build. A static build of topology modules is not
> supported by upstream however:
>
> "Note that it does not make sense to build static topology modules.
> They are not usable."
> https://github.com/alsa-project/alsa-utils/issues/152#issuecomment-1144485929
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/alsa-lib/alsa-lib.mk | 1 +
> ...nfigure.ac-fix-build-without-dlfcn.h.patch | 48 -------------------
> package/alsa-utils/alsa-utils.mk | 3 --
> 3 files changed, 1 insertion(+), 51 deletions(-)
> delete mode 100644 package/alsa-utils/0003-configure.ac-fix-build-without-dlfcn.h.patch
>
> diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
> index f3ed195a5c..6e474aa5e2 100644
> --- a/package/alsa-lib/alsa-lib.mk
> +++ b/package/alsa-lib/alsa-lib.mk
> @@ -25,6 +25,7 @@ endif
> # Can't build with static & shared at the same time (1.0.25+)
> ifeq ($(BR2_STATIC_LIBS),y)
> ALSA_LIB_CONF_OPTS += \
> + --disable-topology \
I think we should make this an explicit Config.in option of the
alsa-lib package, which depends on !BR2_STATIC_LIBS, so that the
packages that need that library can then select this option, and
properly propagate the !BR2_STATIC_LIBS dependency.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-10-30 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 19:15 [Buildroot] [PATCH 1/4] package/alsa-lib: disable topology modules for static builds Bernd Kuhls
2022-10-28 19:15 ` [Buildroot] [PATCH 2/4] package/alsa-plugins: bump version to 1.2.7.1 Bernd Kuhls
2022-10-28 19:15 ` [Buildroot] [PATCH 3/4] package/alsa-lib: bump version to 1.2.8 Bernd Kuhls
2022-10-28 19:15 ` [Buildroot] [PATCH 4/4] package/alsa-utils: " Bernd Kuhls
2022-10-30 14:00 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221030150035.48cf618b@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd.kuhls@t-online.de \
--cc=ckhardin@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox