From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] Makefile: identify silent make via firstword findstring
Date: Sun, 30 Oct 2022 21:26:29 +0100 [thread overview]
Message-ID: <20221030212629.51bf650e@windsurf> (raw)
In-Reply-To: <20221014230905.3091021-1-james.hilliard1@gmail.com>
Hello James,
On Fri, 14 Oct 2022 17:09:05 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> +QUIET := $(if $(findstring s,$(firstword -$(MAKEFLAGS))),-q)
I must be missing something, but why is -$(MAKEFLAGS) used and not just
$(MAKEFLAGS) ?
Indeed, with "make -s --debug -k", $(MAKEFLAGS) is "ks --debug=all",
and therefore $(firstword $(MAKEFLAGS)) is ks, which is good enough for
the findstring s, no? Why is adding a - in front needed?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-30 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 23:09 [Buildroot] [PATCH 1/1] Makefile: identify silent make via firstword findstring James Hilliard
2022-10-30 20:26 ` Thomas Petazzoni via buildroot [this message]
2022-10-30 20:35 ` James Hilliard
2023-04-10 19:44 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221030212629.51bf650e@windsurf \
--to=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox