From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Dimi Tomov <dimi@tpm.dev>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/wolftpm: Update version to v2.6.0
Date: Sun, 30 Oct 2022 22:29:57 +0100 [thread overview]
Message-ID: <20221030222957.2d4a2e0a@windsurf> (raw)
In-Reply-To: <20221012075423.14729-1-dimi@tpm.dev>
On Wed, 12 Oct 2022 10:54:22 +0300
Dimi Tomov <dimi@tpm.dev> wrote:
> From: Dimitar Tomov <dimi@tpm.dev>
>
> This patch series bumps the wolftpm version to the latest available and
> adds one new config option for controlling debug messages in wolftpm.
The commit log of a patch should not describe the patch series, but
just the patch itself.
The commit title should be:
package/wolftpm: bump to version v2.6.0
> package/wolftpm/wolftpm.hash | 2 +-
> package/wolftpm/wolftpm.mk | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/wolftpm/wolftpm.hash b/package/wolftpm/wolftpm.hash
> index d24df58eaa..e256967a01 100644
> --- a/package/wolftpm/wolftpm.hash
> +++ b/package/wolftpm/wolftpm.hash
> @@ -1,4 +1,4 @@
> # Hash from https://github.com/wolfSSL/wolfTPM/archive/refs/tags/v2.4.0.tar.gz
This link is no longer correct. And in fact it is useless. Having a
link here is useful when it's a link to a hash file provided by
upstream, which is not the case here. In this case, we just put
"Locally calculated".
> -sha256 31d1a5f5d60af14c4d07e14a9b0667404d4801fed32afd3fc0649749020ad17b wolftpm-2.4.0.tar.gz
> +sha256 78331cc2d98339247857f5ceb3e7cd3c4f5773e3d81bf1d73e8df9446e37472b wolfTPM-2.6.0.tar.gz
You clearly did not test this properly, as the file is not named
wolfTPM-2.6.0.tar.gz but wolftpm-2.6.0.tar.gz. So a simple build fails
with:
ERROR: No hash found for wolftpm-2.6.0.tar.gz
I've fixed those issues and applied. But the next time, instead of
pinging just one day after submitting your patch... could you rather
spend your time in actually testing your patch?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-10-30 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 7:54 [Buildroot] [PATCH 1/2] package/wolftpm: Update version to v2.6.0 Dimi Tomov
2022-10-12 7:54 ` [Buildroot] [PATCH 2/2] package/wolftpm: Add new config option to enable debug output Dimi Tomov
2022-10-30 21:32 ` Thomas Petazzoni via buildroot
2022-10-13 12:17 ` [Buildroot] [PATCH 1/2] package/wolftpm: Update version to v2.6.0 Dimi Tomov
2022-10-30 21:29 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221030222957.2d4a2e0a@windsurf \
--to=buildroot@buildroot.org \
--cc=dimi@tpm.dev \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox