Re: [Buildroot] [PATCH 3/3] package/ssdp-responder: fix warnings from check-package and shellcheck

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Mon, 31 Oct 2022 18:46:32 +0100
Joachim Wiberg <troglobit@gmail.com> wrote:

> +cmd()
> +{
> +	start-stop-daemon -q -p "$PIDFILE" -x "$DAEMON" "$@"
> +	status=$?
> +	[ $status -eq 0 ] && echo "OK" || echo "FAIL"
> +
> +	return $status
> +}

I don't think we're using this cmd construct anywhere else in the tree,
or did I miss some change in our coding style/policy?

>  
>  start() {
> -	printf 'Starting %s: ' "$NAME"
> -	start-stop-daemon -S -q -p $PIDFILE -x $DAEMON -- $DAEMON_ARGS
> -	[ $? = 0 ] && echo "OK" || echo "FAIL"

This all looked matching our coding style. Why are you changing this?
>  case "$1" in
> -    start|stop|restart)
> -	"$1"
> -	;;
> -    reload)
> -	restart
> -	;;
> -    *)
> -	echo "Usage: $0 {start|stop|restart|reload}"
> -	exit 1
> +	start|stop|restart)
> +		"$1"
> +		;;
> +	reload)
> +		restart
> +		;;
> +	*)
> +		echo "Usage: $0 {start|stop|restart|reload}"
> +		exit 1

I'm not sure what is the recommended indentation style in our init
scripts. Tabs? Spaces?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot