Re: [Buildroot] [PATCH 1/1] package/opencv4: add support for opencv4_contrib repository for extra modules

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Woody,

On Thu, 3 Nov 2022 22:30:21 +0000
Woody Douglass <wdouglass@carnegierobotics.com> wrote:

> This adds a separate opencv4_contrib package to manage
> downloading/unpacking that repository. These extra modules
> are useful for a lot of applications, but not necessary
> for minimal installs, so they are all given dedicated Kconfig
> options
> 
> Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>

Thanks a lot for your patch! One issue is that because you did not send
it with "git send-email", it arrived on the mailing list badly damaged
(line-wrapped)  by your e-mail client.

Also, one thing that really should be explained in the commit log is
that the opencv4-contrib is only useful to download additional source,
but that it actually gets built as part of the opencv4 package itself,
which is why opencv4-contrib is a dependency of opencv4 and not the
other way around.

Even though this is quite unusual, it should be noted that it is not
the first case we have: nginx modules are handled in the same way
(see nginx-upload, nginx-dav-ext, nginx-naxsi, nginx-modsecurity).

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot