From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Vincent Fazio <vfazio@xes-inc.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/swupdate: specify SWU_VER during build
Date: Sat, 5 Nov 2022 21:03:31 +0100 [thread overview]
Message-ID: <20221105210331.2d1aad17@windsurf> (raw)
In-Reply-To: <20221104151242.2735240-1-vfazio@xes-inc.com>
On Fri, 4 Nov 2022 10:12:42 -0500
Vincent Fazio <vfazio@xes-inc.com> wrote:
> The swupdate build process uses SWU_VER as part of the build commandline
> for compiling objects to define the value for use in globals.h (see also
> Makefile.flags).
>
> This value is also used to communicate capabilities to lua handlers
> (see upstream 0f38ff186e76c55c8d00ccb53739a29bcca91445).
>
> When swupdate gets built, SWU_VER defaults to using `git describe` to
> determine the version. This, unfortunately, picks up the version of the
> Buildroot checkout and not the actual version of swupdate.
>
> Now, specify SWU_VER as part of the make options to override the
> calculated value so the proper version is reported.
>
> Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
> ---
> package/swupdate/swupdate.mk | 1 +
> 1 file changed, 1 insertion(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-11-05 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 15:12 [Buildroot] [PATCH 1/1] package/swupdate: specify SWU_VER during build Vincent Fazio
2022-11-05 20:03 ` Thomas Petazzoni via buildroot [this message]
2022-11-14 15:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221105210331.2d1aad17@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vfazio@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox