Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Kamel Bouhara <kamel.bouhara@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libqb: disable tests
Date: Sat, 5 Nov 2022 21:40:36 +0100	[thread overview]
Message-ID: <20221105214036.49e34b51@windsurf> (raw)
In-Reply-To: <20221103234342.351104-1-fontaine.fabrice@gmail.com>

On Fri,  4 Nov 2022 00:43:42 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Disable tests to avoid the following build failure when check is
> enabled:
> 
> libstat_wrapper.c:11:10: fatal error: gnu/lib-names.h: No such file or directory
>    11 | #include <gnu/lib-names.h>
>       |          ^~~~~~~~~~~~~~~~~
> 
> This build failure is raised since bump to version 2.0.6 in commit
> 2ee1bd7bb2e8d01f4ddca3fb1127ec729be1c9bf and
> https://github.com/ClusterLabs/libqb/commit/78df90b180740712d0c90b6d982b78241cc99d72
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/450cfc36d4fd6dc71c138bec45f05b5a2d92a08d
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  .../libqb/0001-Add-disable-tests-option.patch | 62 +++++++++++++++++++
>  package/libqb/libqb.mk                        |  3 +
>  2 files changed, 65 insertions(+)
>  create mode 100644 package/libqb/0001-Add-disable-tests-option.patch

So I have applied but like upstream said, I think the actual build
issue should be resolved. Disabling tests is really just a work around:
people who want to build tests will still face the same build issue. So
I had a look, and from my point of view, the <gnu/lib-names.h> include
is simply useless and can be removed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-11-05 20:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 23:43 [Buildroot] [PATCH 1/1] package/libqb: disable tests Fabrice Fontaine
2022-11-05 20:40 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221105214036.49e34b51@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=kamel.bouhara@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox