Re: [Buildroot] [PATCH 1/1] andes_ae350_45_defconfig: bump opensbi, u-boot and linux

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Fri, 4 Nov 2022 16:04:07 +0800
Yu Chien Peter Lin <peterlin@andestech.com> wrote:

> This patch bumps following packages to the newer version:
> - OpenSBI v1.1
> - U-boot v2022.10
> - Linux 6.0
> 
> Linux kernel is hosted on AndesTech Github which includes ethernet,
> SD card, DMAC, RTC, WDT drivers support. OpenSBI is based on v1.1
> with andes platfrom fdt driver, hence adding patches for U-boot to
> update the plmt and plicsw compatible strings and modify the IPI scheme.
> 
> Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
> ---
>  board/andes/ae350/ae350.dts                   | 274 ------------------
>  board/andes/ae350/genimage_sdcard.cfg         |   2 +-
>  ...isable-PIC-explicitly-for-assembling.patch |  29 --
>  ...2-Enable-cache-for-opensbi-jump-mode.patch |  25 --
>  ...001-Fix-mmc-no-partition-table-error.patch |  27 --
>  ...-Support-DTS-of-ftsdc010-driver-for-.patch |  35 +++
>  ...2-Prevent-fw_dynamic-from-relocation.patch |  27 --
>  ...-tree-blob-address-at-8-byte-boundar.patch |  37 +++
>  ...0003-Fix-u-boot-proper-booting-issue.patch |  26 --
>  ...andes_plic.c-use-modified-IPI-scheme.patch |  43 +++
>  ...04-Enable-printing-OpenSBI-boot-logo.patch |  25 --
>  ...04-riscv-Rename-Andes-PLIC-to-PLICSW.patch | 263 +++++++++++++++++
>  board/andes/ae350/post-build.sh               |   2 +-
>  board/andes/ae350/readme.txt                  |   4 +-
>  .../boot/extlinux/extlinux.conf               |   2 +-
>  board/andes/ae350/uboot.config.fragment       |   6 +-
>  configs/andes_ae350_45_defconfig              |  16 +-
>  17 files changed, 394 insertions(+), 449 deletions(-)
>  delete mode 100755 board/andes/ae350/ae350.dts
>  delete mode 100644 board/andes/ae350/patches/opensbi/0001-Disable-PIC-explicitly-for-assembling.patch
>  delete mode 100644 board/andes/ae350/patches/opensbi/0002-Enable-cache-for-opensbi-jump-mode.patch
>  delete mode 100644 board/andes/ae350/patches/uboot/0001-Fix-mmc-no-partition-table-error.patch
>  create mode 100644 board/andes/ae350/patches/uboot/0001-mmc-ftsdc010_mci-Support-DTS-of-ftsdc010-driver-for-.patch
>  delete mode 100644 board/andes/ae350/patches/uboot/0002-Prevent-fw_dynamic-from-relocation.patch
>  create mode 100644 board/andes/ae350/patches/uboot/0002-spl-Align-device-tree-blob-address-at-8-byte-boundar.patch
>  delete mode 100644 board/andes/ae350/patches/uboot/0003-Fix-u-boot-proper-booting-issue.patch
>  create mode 100644 board/andes/ae350/patches/uboot/0003-riscv-andes_plic.c-use-modified-IPI-scheme.patch
>  delete mode 100644 board/andes/ae350/patches/uboot/0004-Enable-printing-OpenSBI-boot-logo.patch
>  create mode 100644 board/andes/ae350/patches/uboot/0004-riscv-Rename-Andes-PLIC-to-PLICSW.patch

It looks mostly good. Could you however:

 (1) Add your Signed-off-by inside each of the U-Boot patches you are
 introducing, as well as provide a link to where the patches were
 downloaded from?

 (2) Remove the numbering in the U-Boot patch titles. I.e instead of
 [PATCH 1/2], we want to see [PATCH]. Use "git format-patch -N" to not
 have this numbering.

 (3) Keep the correct BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_xxyz=y
 option in the defconfig?

With these changes, your patch will be ready to be applied.

Also, are those U-Boot changes going to be accepted in upstream U-Boot?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot