Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Marek Belisko <marek.belisko@open-nandra.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/udisks: add config option to support mounting in, /media
Date: Wed, 9 Nov 2022 23:10:58 +0100	[thread overview]
Message-ID: <20221109231058.6265929b@windsurf> (raw)
In-Reply-To: <b1bafa9c-393e-b9aa-0a3e-0a3e67c5fd42@grandegger.com>

Hello Wolfgang,

On Tue, 8 Nov 2022 18:22:03 +0100
Wolfgang Grandegger <wg@grandegger.com> wrote:

> Support mounting in /media instead of /run/media for compatibility
> with the Filesystem Hierarchy Standard (FHS). This is also required
> for backward compatibility with udisks1.

Could you resend with your Signed-off-by: line? Also see below another
comment.

>   comment "udisks can't be built with Optimize for fast"
>   	depends on BR2_OPTIMIZE_FAST
> +
> +if BR2_PACKAGE_UDISKS
> +
> +config BR2_PACKAGE_UDISKS_FHS_MEDIA
> +	bool "Mount devices in /media instead of /run/media"
> +	help
> +	  Support mounting in /media for compatibility with the
> +	  Filesystem Hierarchy Standard (FHS)
> +
> +endif
> diff --git a/package/udisks/udisks.mk b/package/udisks/udisks.mk
> index 2bf519a2cc..91328effba 100644
> --- a/package/udisks/udisks.mk
> +++ b/package/udisks/udisks.mk
> @@ -39,4 +39,8 @@ UDISKS_CONF_OPTS = \
>   	--disable-vdo \
>   	--disable-zram
>   
> +ifeq ($(BR2_PACKAGE_UDISKS_FHS_MEDIA),y)
> +UDISKS_CONF_OPTS += --enable-fhs-media

Could you add:

else
UDISKS_CONF_OPTS += --disable-fhs-media

So that we are explicit about what happens when the option is disabled?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-11-09 22:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 17:22 [Buildroot] [PATCH] package/udisks: add config option to support mounting in, /media Wolfgang Grandegger
2022-11-09 22:10 ` Thomas Petazzoni via buildroot [this message]
2022-11-10  8:11   ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221109231058.6265929b@windsurf \
    --to=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=marek.belisko@open-nandra.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox