From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/3] package/zxing-cpp: bump to version 1.4.0
Date: Mon, 14 Nov 2022 23:45:32 +0100 [thread overview]
Message-ID: <20221114234532.3aa355df@windsurf> (raw)
In-Reply-To: <20221107022458.3448020-2-james.hilliard1@gmail.com>
Hello James,
On Sun, 6 Nov 2022 19:24:57 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:
> -ifeq ($(BR2_PACKAGE_LIBICONV),y)
> -ZXING_CPP_DEPENDENCIES += libiconv
> +ifeq ($(BR2_PACKAGE_OPENCV3_LIB_HIGHGUI)$(BR2_PACKAGE_OPENCV4_LIB_HIGHGUI),y)
> +ifeq ($(BR2_PACKAGE_OPENCV3),y)
> +ZXING_CPP_DEPENDENCIES += opencv3
> +endif
> +ifeq ($(BR2_PACKAGE_OPENCV4),y)
> +ZXING_CPP_DEPENDENCIES += opencv4
> +endif
> +ZXING_CPP_CONF_OPTS += -DCMAKE_REQUIRE_FIND_PACKAGE_OpenCV=TRUE
> +else
> +ZXING_CPP_CONF_OPTS += -DCMAKE_DISABLE_FIND_PACKAGE_OpenCV=TRUE
> endif
>
> -ifeq ($(BR2_PACKAGE_OPENCV3_LIB_HIGHGUI),y)
> -ZXING_CPP_DEPENDENCIES += opencv3
> -ZXING_CPP_CONF_OPTS += -DBUILD_OPENCV=ON
> +ifeq ($(BR2_PACKAGE_PYTHON3)$(BR2_PACKAGE_PYTHON_PYBIND),y)
Are you sure this is correct? I believe it should be:
ifeq ($(BR2_PACKAGE_PYTHON3)$(BR2_PACKAGE_PYTHON_PYBIND),yy)
or:
ifeq ($(BR2_PACKAGE_PYTHON3),y)
since anyway pybind is guaranteed to be available when python3 is
enabled, since you select it.
> +ZXING_CPP_DEPENDENCIES += python3 python-pybind
> +ZXING_CPP_CONF_OPTS += -DBUILD_PYTHON_MODULE=ON
> +else
> +ZXING_CPP_CONF_OPTS += -DBUILD_PYTHON_MODULE=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_QT5BASE),y)
> +ZXING_CPP_DEPENDENCIES += qt5base
> +ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK)$(BR2_PACKAGE_QT5MULTIMEDIA),yy)
> +ZXING_CPP_DEPENDENCIES += qt5declarative qt5multimedia
> +endif
> +ifeq ($(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5DECLARATIVE_QUICK)$(BR2_PACKAGE_QT5MULTIMEDIA),yyy)
> +ZXING_CPP_CONF_OPTS += -DCMAKE_REQUIRE_FIND_PACKAGE_Qt5=TRUE
it's a bit confusing what's happening here. Why are the dependencies
different than the condition used to enable Qt support?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-11-14 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 2:24 [Buildroot] [PATCH 1/3] package/stb: new package James Hilliard
2022-11-07 2:24 ` [Buildroot] [PATCH 2/3] package/zxing-cpp: bump to version 1.4.0 James Hilliard
2022-11-14 22:45 ` Thomas Petazzoni via buildroot [this message]
2022-11-14 22:50 ` James Hilliard
2022-11-14 23:31 ` James Hilliard
2022-11-07 2:24 ` [Buildroot] [PATCH 3/3] package/gstreamer1/gst1-plugins-bad: add zxing plugin support James Hilliard
2022-11-14 22:43 ` [Buildroot] [PATCH 1/3] package/stb: new package Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114234532.3aa355df@windsurf \
--to=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox