From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 1/1] package/iwd: add dbus compile time dependency
Date: Tue, 22 Nov 2022 22:35:25 +0100 [thread overview]
Message-ID: <20221122223525.3d833030@windsurf> (raw)
In-Reply-To: <20221031174959.604094-1-james.hilliard1@gmail.com>
On Mon, 31 Oct 2022 11:49:59 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> In 5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4 we dropped dbus as a build
> dependency, however we still need it when building with systemd so
> that the service directory is available via pkg-config.
>
> In addition we can drop --with-dbus-datadir by unconditionally
> requiring dbus as the datadir will then be fetched from pkg-config.
>
> Fixes:
> checking D-Bus bus services directory... configure: error: D-Bus bus services directory is required
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Changes v2 -> v3:
> - always depend on dbus
> Changes v1 -> v2:
> - depend on dbus when depending on systemd
> ---
> package/iwd/iwd.mk | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Applied to master after adding a reference to the autobuilder failure.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-11-22 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 17:49 [Buildroot] [PATCH v3 1/1] package/iwd: add dbus compile time dependency James Hilliard
2022-11-14 7:18 ` Lang Daniel via buildroot
2022-11-14 13:35 ` James Hilliard
2022-11-22 21:35 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122223525.3d833030@windsurf \
--to=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox