From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Marek Metelski <marek.metelski@grinn-global.com>
Cc: Romain Naour <romain.naour@gmail.com>,
Marcin Niestroj <m.niestroj@grinn-global.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/gitlab-runner: fix inconsistency of systemd and sysv daemons
Date: Tue, 22 Nov 2022 22:50:12 +0100 [thread overview]
Message-ID: <20221122225012.18ef6ade@windsurf> (raw)
In-Reply-To: <20221107091658.25974-1-marek.metelski@grinn-global.com>
On Mon, 7 Nov 2022 10:16:58 +0100
Marek Metelski <marek.metelski@grinn-global.com> wrote:
> Copy default $DEAMON_ARGS from systemd service to sysv init script.
>
> Make GITLAB_RUNNER_USER home directory the same as default
> --work-directory (-d) flag.
>
> Run sysv daemon process using root user (remove -c option)
> This is needed to correctly access config files as specified.
> System access can still be limited with gitlab-runner `--user` flag.
>
> Use same $DAEMON_ARGS variable name so it can be overwritten in
> /etc/default/gitlab-runner environment file in both cases.
>
> Signed-off-by: Marek Metelski <marek.metelski@grinn-global.com>
> ---
> package/gitlab-runner/S95gitlab-runner | 6 +++---
> package/gitlab-runner/gitlab-runner.mk | 3 +--
> 2 files changed, 4 insertions(+), 5 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-11-22 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 9:16 [Buildroot] [PATCH 1/1] package/gitlab-runner: fix inconsistency of systemd and sysv daemons Marek Metelski
2022-11-07 16:58 ` Marcin Niestrój
2022-11-22 21:50 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122225012.18ef6ade@windsurf \
--to=buildroot@buildroot.org \
--cc=m.niestroj@grinn-global.com \
--cc=marek.metelski@grinn-global.com \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox