Re: [Buildroot] [PATCH 1/1] package/sscep: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Dario,

On Fri, 11 Nov 2022 14:32:54 +0100
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:

> SSCEP is a client-only implementation of the SCEP (Cisco System's Simple
> Certificate Enrollment Protocol).
> 
> The goal of SCEP is to support the secure issuance of certificates to
> network devices in a scalable manner, using existing technology whenever
> possible. The protocol supports the following operations:
> 
> * CA and RA public key distribution
> * Certificate enrollment
> * Certificate and CRL query
> 
> Certificate and CRL access can be achieved by using the LDAP protocol,
> or by using the query messages defined in SCEP.
> 
> CC: Angelo Compagnucci <angelo@amarulasolutions.com>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Thanks for your contribution. I applied to master, but after fixing a
number of things. See below.


> diff --git a/package/sscep/Config.in b/package/sscep/Config.in
> new file mode 100644
> index 000000000000..d4847f1b8a75
> --- /dev/null
> +++ b/package/sscep/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_SSCEP
> +	bool "sscep"
> +	depends on BR2_PACKAGE_OPENSSL

This should have been a "select", not a "depends on".

> diff --git a/package/sscep/sscep.mk b/package/sscep/sscep.mk
> new file mode 100644
> index 000000000000..f59f4bd03bbc
> --- /dev/null
> +++ b/package/sscep/sscep.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# sscep
> +#
> +################################################################################
> +
> +SSCEP_VERSION = v0.10.0
> +SSCEP_SITE = $(call github,certnanny,sscep,$(SSCEP_VERSION))

This should have been:

+SSCEP_VERSION = 0.10.0
+SSCEP_SITE = $(call github,certnanny,sscep,v$(SSCEP_VERSION))

I.e the "v" prefix should not be in the VERSION variable.

> +SSCEP_LICENSE = BSD

BSD is not a valid SPDX license code and is not specific enough. I've
changed this to:

+SSCEP_LICENSE = BSD-2-Clause, OpenSSL, OpenOSP


> +SSCEP_LICENSE_FILES = COPYING
> +SSCEP_AUTORECONF = YES
> +SSCEP_DEPENDENCIES += openssl

+= is not needed, a simple = is sufficient. But more importantly, the
host-pkgconf dependency was missing, causing the package to fail
building.

I've addressed all those small issues when committing.

Thanks again!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot