From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/rtl8188eu: fix build failure on PowerPC
Date: Mon, 28 Nov 2022 10:55:35 +0100 [thread overview]
Message-ID: <20221128105535.5a2c0798@booty> (raw)
In-Reply-To: <20221127132855.510943-1-giulio.benetti@benettiengineering.com>
Hi Giulio,
On Sun, 27 Nov 2022 14:28:55 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Add local patch(pending upstream[0]) to fix build failure with PowerPC due
> to a package re-defition of get_ra() that is only defined in Linux PowerPC
> implementation.
>
> [0]: https://github.com/lwfinger/rtl8188eu/pull/432
>
> Fixes:
> http://autobuild.buildroot.net/results/8bcb4d0adabc141ff8144f9e22bd549e3cd8858a/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> ...uild-failure-on-PowerPc-architecture.patch | 106 ++++++++++++++++++
> 1 file changed, 106 insertions(+)
> create mode 100644 package/rtl8188eu/0001-Fix-build-failure-on-PowerPc-architecture.patch
>
> diff --git a/package/rtl8188eu/0001-Fix-build-failure-on-PowerPc-architecture.patch b/package/rtl8188eu/0001-Fix-build-failure-on-PowerPc-architecture.patch
> new file mode 100644
> index 0000000000..b16a312c7e
> --- /dev/null
> +++ b/package/rtl8188eu/0001-Fix-build-failure-on-PowerPc-architecture.patch
> @@ -0,0 +1,106 @@
> +From 2a91a721d634a2eca131628b5c9c028af20037af Mon Sep 17 00:00:00 2001
> +From: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +Date: Sun, 27 Nov 2022 14:20:43 +0100
> +Subject: [PATCH] Fix build failure on PowerPc architecture
> +
> +In PowerPc Linux only get_ra() exists[0] and conflicts with local get_ra()
> +that has a completely different purpose. So let's rename local get_ra()
> +to wifi_get_ra() to make it different from Linux's get_ra().
> +
> +[0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/include/asm
> +
> +Upstream: https://github.com/lwfinger/rtl8188eu/pull/432
> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Thank you!
I have posted some change request to the commit message on your patch
for upstream, but the patch content itself looks good, so I guess for
the Buildroot needs this is enough:
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-11-28 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 13:28 [Buildroot] [PATCH] package/rtl8188eu: fix build failure on PowerPC Giulio Benetti
2022-11-28 9:55 ` Luca Ceresoli via buildroot [this message]
2022-11-28 13:57 ` Giulio Benetti
2022-11-29 14:16 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128105535.5a2c0798@booty \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=luca.ceresoli@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox