Re: [Buildroot] [PATCH 2/3 next] package/edk2-non-osi: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Vincent Stehlé" <vincent.stehle@arm.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/3 next] package/edk2-non-osi: new package
Date: Sun, 4 Dec 2022 14:08:09 +0100	[thread overview]
Message-ID: <20221204140809.5159d22f@windsurf> (raw)
In-Reply-To: <20221201183337.1588407-3-vincent.stehle@arm.com>

On Thu,  1 Dec 2022 19:33:36 +0100
Vincent Stehlé <vincent.stehle@arm.com> wrote:

> Add a package to install the additional edk2 platforms files, not
> compatible with the normal licensing requirements and held in the
> edk2-non-osi repository.
> 
> Only the Marvell Armada files are copied at this point, to support building
> edk2 for the MACCHIATObin platform.
> 
> The referenced commit corresponds to version edk2-stable202208 of edk2,
> based on the timestamps.
> 
> This package is heavily inspired from package/edk2-platforms.
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

To be honest, I don't really understand the reasoning of the move of
the Marvell files to this edk2-non-osi repository. Indeed, they are
under BSD-2-Patent, which is an OSI-compatible license.

But anyway...

> +# Copy Marvell Armada files
> +EDK2_NON_OSI_LICENSE += , BSD-2-Clause-Patent (Marvell Armada)

I changed the += and removed the comma, as for now we only have this
particular license, and we don't want the _LICENSE variable value to
start with a comma.

> +EDK2_NON_OSI_LICENSE_FILES += Silicon/Marvell/Armada7k8k/DeviceTree/Armada80x0McBin.inf
> +EDK2_NON_OSI_DIRS += Silicon/Marvell/Armada7k8k/DeviceTree
> +
> +# There is nothing to build for edk2-non-osi. All we need to do is to copy
> +# the selected description files to staging, for other packages to build with.
> +define EDK2_NON_OSI_INSTALL_STAGING_CMDS
> +	mkdir -p $(STAGING_DIR)/usr/share/edk2-non-osi

I removed this mkdir, since anway you are using mkdir -p below to
create the subdirs.

> +	for d in $(EDK2_NON_OSI_DIRS); do \
> +		mkdir -p $(STAGING_DIR)/usr/share/edk2-non-osi/$$d; \
> +		cp -rf $(@D)/$$d/* $(STAGING_DIR)/usr/share/edk2-non-osi/$$d/; \
> +	done

Reworked with a make foreach loop so that i aborts in case of a failure.

Applied to next with those changes.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot