From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Patrick Gerber <pge@ik.me>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/mender-artifact: remove unnecessary GO_ENV
Date: Sun, 4 Dec 2022 18:36:12 +0100 [thread overview]
Message-ID: <20221204173612.GB2855@scaer> (raw)
In-Reply-To: <20221204140643.893075-2-pge@ik.me>
Patrick, All,
On 2022-12-04 15:06 +0100, Patrick Gerber via buildroot spake thusly:
> All go packages are built with:
> GOFLAGS="-mod=vendor"
> (see HOST_GO_COMMON_ENV in go/go.mk)
>
> Signed-off-by: Patrick Gerber <pge@ik.me>
I slightly extended the commit log to explain why mender-artifacts had
that settings to begin with and applied to next, thanks.
Regards,
Yann E. MORIN.
> ---
> package/mender-artifact/mender-artifact.mk | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/package/mender-artifact/mender-artifact.mk b/package/mender-artifact/mender-artifact.mk
> index 1031166f34..6ade624a23 100644
> --- a/package/mender-artifact/mender-artifact.mk
> +++ b/package/mender-artifact/mender-artifact.mk
> @@ -86,14 +86,6 @@ HOST_MENDER_ARTIFACT_LICENSE_FILES = \
>
> HOST_MENDER_ARTIFACT_DEPENDENCIES = host-xz
>
> -# By default, go will attempt to download needed modules before building, which
> -# is not desirable. This behavior also causes permission issues when cleaning,
> -# as go downloads modules as read-only by default. Because mender-artifact
> -# includes the modules in the vendor directory, mod=vendor prevents the package
> -# from downloading the go modules during the build process and prevents
> -# permission issues when cleaning.
> -HOST_MENDER_ARTIFACT_GO_ENV = GOFLAGS="-mod=vendor"
> -
> HOST_MENDER_ARTIFACT_LDFLAGS = -X github.com/mendersoftware/mender-artifact/cli.Version=$(HOST_MENDER_ARTIFACT_VERSION)
>
> HOST_MENDER_ARTIFACT_BIN_NAME = mender-artifact
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-12-04 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 14:06 [Buildroot] [PATCH 1/2] package/pkg-golang: enable pkg specific go env also for download step Patrick Gerber via buildroot
2022-12-04 14:06 ` [Buildroot] [PATCH 2/2] package/mender-artifact: remove unnecessary GO_ENV Patrick Gerber via buildroot
2022-12-04 17:36 ` Yann E. MORIN [this message]
2022-12-04 17:35 ` [Buildroot] [PATCH 1/2] package/pkg-golang: enable pkg specific go env also for download step Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221204173612.GB2855@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=pge@ik.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox