Re: [Buildroot] [PATCH 1/1] package/tealdeer: exclude unsupported targets

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Danilo,

On Thu, 8 Dec 2022 11:02:47 +0100
Danilo Bargen <mail@dbrgn.ch> wrote:

> Not all target architectures are supported by the "ring" dependency.
> 
> Signed-off-by: Danilo Bargen <mail@dbrgn.ch>

Thanks for working on this. Your patch is badly line-wrapped by your
e-mail client. You can disable wrapping in Claws Mail, or better you
can use "git send-email". See below for another comment.

> diff --git a/package/tealdeer/Config.in b/package/tealdeer/Config.in
> index 96ed81614b..a61a59f3ee 100644
> --- a/package/tealdeer/Config.in
> +++ b/package/tealdeer/Config.in
> @@ -1,6 +1,14 @@
>  config BR2_PACKAGE_TEALDEER
>  	bool "tealdeer"
>  	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
> +    # Crypto dependency (ring) not available for mips:
> https://github.com/briansmith/ring/issues/562
> +    depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el)
> +    # Crypto dependency (ring) not available for PowerPC:
> https://github.com/briansmith/ring/issues/389
> +    depends on !(BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le)
> +    # Crypto dependency (ring) not available for Sparc:
> https://github.com/briansmith/ring/issues/1512
> +    depends on !(BR2_sparc || BR2_sparc64)
> +    # Crypto dependency (ring) not available for s390x:
> https://github.com/briansmith/ring/commit/4d2e1a8fb80398f7c3c0137ea8fdd512f82d37a0
> +    depends on !BR2_s390x

We normally handle this kind of situation using a
BR2_PACKAGE_TEALDEER_ARCH_SUPPORTS variable, like this:

config BR2_PACKAGE_TEALDEER_ARCH_SUPPORTS
	bool
	default y if ...
	depends on ...

config BR2_PACKAGE_TEALDEER
	bool "tealdeer"
	depends on BR2_PACKAGE_TEALDEER_ARCH_SUPPORTS

Also, in this kind of case, we prefer to use "positive" logic: instead
of excluding the architectures that are not supported, it is better to
list the ones that are supported.

Side note: overall, if you take a step back, it is absolutely
mind-blowing that a simple application showing tldr pages has a
dependency on architecture-specific things. There is really no sane
reason to have such dependencies, but apparently the Rust ecosystem is
not completely sane... :-/

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot