Re: [Buildroot] [PATCH v1 1/2] board/zynqmp/zcu106/patches: remove patch

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Neal,

On Wed, 7 Dec 2022 05:21:32 -0700
Neal Frager via buildroot <buildroot@buildroot.org> wrote:

> The 0001-arm64-zynqmp-zynqmp-zcu106-revA-Fix-DP-PLL-configura.patch
> is already committed in the Xilinx 2022.2 u-boot release tag.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
>  ...qmp-zcu102-revA-Fix-DP-PLL-configura.patch | 40 -------------------
>  configs/zynqmp_zcu106_defconfig               |  1 -
>  2 files changed, 41 deletions(-)
>  delete mode 100644 board/zynqmp/zcu106/patches/uboot/0001-arm64-zynqmp-zynqmp-zcu102-revA-Fix-DP-PLL-configura.patch

This should have been part of the commit updating U-Boot. If you didn't
notice then, then this commit should have been very different: (1) it
should clearly indicate that it fixes a bug and (2) it should point to
the commit it is fixing. I've committed with the following commit log:

    board/zynqmp/zcu106/patches: fix build by dropping U-Boot patch
    
    Since commit
    3c997c457a4ee33d81e6b93e4f6f147bb9e861e9 ("configs/zynqmp_zcu106_defconfig:
    bump to Xilinx 2022.2"), we're using U-Boot version Xilinx 2022.2,
    which already carries the psu_init_gpl.c, causing the build to fail as
    our patch doesn't apply.
    
    Fix this by dropping the no longer needed patch.
    
    Fixes: 3c997c457a4ee33d81e6b93e4f6f147bb9e861e9 ("configs/zynqmp_zcu106_defconfig: bump to Xilinx 2022.2")
    Signed-off-by: Neal Frager <neal.frager@amd.com>
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot