From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Neal Frager via buildroot <buildroot@buildroot.org>
Cc: luca.ceresoli@bootlin.com, michal.simek@amd.com,
Neal Frager <neal.frager@amd.com>
Subject: Re: [Buildroot] [PATCH v1 1/1] configs/zynqmp_kria_kv260_defconfig: fix linux dts name
Date: Sun, 11 Dec 2022 18:03:36 +0100 [thread overview]
Message-ID: <20221211180336.79ea5b05@windsurf> (raw)
In-Reply-To: <20221207124855.1831-1-neal.frager@amd.com>
Hello,
On Wed, 7 Dec 2022 05:48:55 -0700
Neal Frager via buildroot <buildroot@buildroot.org> wrote:
> The Linux DTS name has changed for the zynqmp_kria_kv260 with Xilinx 2022.2.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> configs/zynqmp_kria_kv260_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configs/zynqmp_kria_kv260_defconfig b/configs/zynqmp_kria_kv260_defconfig
> index df01ad30b8..aef67b3cb4 100644
> --- a/configs/zynqmp_kria_kv260_defconfig
> +++ b/configs/zynqmp_kria_kv260_defconfig
> @@ -8,7 +8,7 @@ BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,Xilinx,linux-xlnx,xlnx_rebase_v5.15_LTS_2022.2)/xlnx_rebase_v5.15_LTS_2022.2.tar.gz"
> BR2_LINUX_KERNEL_DEFCONFIG="xilinx_zynqmp"
> BR2_LINUX_KERNEL_DTS_SUPPORT=y
> -BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/smk-k26-revA-sck-kv-g-revB"
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/zynqmp-smk-k26-revA-sck-kv-g-revB"
Do you test your patches before sending them? Because it's quite
worrying to have some many fixes.
And in fact, it seems this patch is also broken: there is no Device
Tree named zynqmp-smk-k26-revA-sck-kv-g-revB.dts:
$ make zynqmp_kria_kv260_defconfig
$ make linux-patch
$ find output/build/linux-custom/ -name 'zynqmp-smk-k26-revA-sck-kv-g-revB.dts'
$
So unless I'm wrong, this patch doesn't look correct.
Please make sure to do a full build of your defconfigs (make clean;
make foobar_defconfig; make) before sending an update to your defconfig.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-12-11 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 12:48 [Buildroot] [PATCH v1 1/1] configs/zynqmp_kria_kv260_defconfig: fix linux dts name Neal Frager via buildroot
2022-12-11 17:03 ` Thomas Petazzoni via buildroot [this message]
2022-12-11 17:55 ` Frager, Neal via buildroot
2022-12-12 13:47 ` Frager, Neal via buildroot
2022-12-19 12:36 ` Luca Ceresoli via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221211180336.79ea5b05@windsurf \
--to=buildroot@buildroot.org \
--cc=luca.ceresoli@bootlin.com \
--cc=michal.simek@amd.com \
--cc=neal.frager@amd.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox