Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Brandon Maier <brandon.maier@collins.com>
Cc: Neal Frager <neal.frager@amd.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] boot/uboot/uboot.mk: support binary pm_cfg_obj
Date: Mon, 12 Dec 2022 10:31:36 +0100	[thread overview]
Message-ID: <20221212103136.71c0a850@booty> (raw)
In-Reply-To: <20221209194043.28673-1-brandon.maier@collins.com>

Hello Brandon,

thanks for your patch.

On Fri,  9 Dec 2022 13:40:43 -0600
Brandon Maier <brandon.maier@collins.com> wrote:

> BR2_TARGET_UBOOT_ZYNQMP_PM_CFG only works with C files, as it always
> tries to process them through tools/zynqmp_pm_cfg_obj_convert.py. Rework
> the logic so if the pm_cfg_obj isn't a C file, it is provided directly
> to U-Boot.

Can you describe a use case where this would be useful? While I
intuitively understand there _might_ be some, I cannot find any good
example based on my experience.

Building the pm_cfg_obj from source code is very easily done by
Buildroot, unlike building the PMUFW. Additionally one PMUFW binary
can be used on multiple zynqmp hardware, while the cfg obj is very
likely to change across different projects, and a somewhat readable
text file is way more understandable than a binary blob.

> This mimics changes done to the ZYNQMP_PMUFW which had a similar issue.

That is different: we now support two different binary formats, not
binary-vs-source, and detection is based on the file extension.

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-12-12  9:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09 19:40 [Buildroot] [PATCH 1/1] boot/uboot/uboot.mk: support binary pm_cfg_obj Brandon Maier via buildroot
2022-12-10  9:55 ` Frager, Neal via buildroot
2022-12-12  9:35   ` Luca Ceresoli via buildroot
2022-12-12  9:43     ` Frager, Neal via buildroot
2022-12-12  9:31 ` Luca Ceresoli via buildroot [this message]
2022-12-12 12:52   ` Frager, Neal via buildroot
2022-12-13  8:23     ` Luca Ceresoli via buildroot
2022-12-12 15:41   ` [Buildroot] [External] " Maier, Brandon L Collins via buildroot
2022-12-13  8:21     ` Luca Ceresoli via buildroot
2022-12-22 14:37     ` Frager, Neal via buildroot
2022-12-29 22:42       ` Luca Ceresoli via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221212103136.71c0a850@booty \
    --to=buildroot@buildroot.org \
    --cc=brandon.maier@collins.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=neal.frager@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox