From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/crun: needs fexecve
Date: Sun, 8 Jan 2023 16:52:30 +0100 [thread overview]
Message-ID: <20230108155230.GD151997@scaer> (raw)
In-Reply-To: <20221230175350.412551-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2022-12-30 18:53 +0100, Fabrice Fontaine spake thusly:
> crun unconditionally uses fexecve since its addition in commit
> 530d6f661e506a4774b7236cb93d65f669adbc92 and
> https://github.com/containers/crun/commit/ce4dfbb97a8a05bef125030eaa6c46c07a5f9344:
> resulting in the following uclibc build failure:
>
> /tmp/instance-11/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arceb-snps-linux-uclibc/9.2.1/../../../../arceb-snps-linux-uclibc/bin/ld: src/libcrun/crun-cloned_binary.o: in function `ensure_cloned_binary':
> cloned_binary.c:(.text+0x1006): undefined reference to `fexecve'
I slightly extended the commit log to refer to commit 6e3f7fbc072c,
which made runc also unavailable for uclibc toolchain for the exact
same reason (crun having copied from runc; damn, that naming is not
confusing at all...)
> Fixes:
> - http://autobuild.buildroot.org/results/e1f4ef2b392c0e7161390ba0f97d6eef3bd12e9c
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/crun/Config.in | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/package/crun/Config.in b/package/crun/Config.in
> index 5def7001c1..fa0894e126 100644
> --- a/package/crun/Config.in
> +++ b/package/crun/Config.in
> @@ -1,8 +1,12 @@
> config BR2_PACKAGE_CRUN
> bool "crun"
> - select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
> + depends on !BR2_TOOLCHAIN_USES_UCLIBC # no fexecve
> + select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_MUSL
> select BR2_PACKAGE_YAJL # libocispec
> help
> crun is a fast and low-memory OCI Container Runtime in C.
>
> https://github.com/containers/crun
> +
> +comment "crun needs a glibc or musl toolchain"
> + depends on BR2_TOOLCHAIN_USES_UCLIBC
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-01-08 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 17:53 [Buildroot] [PATCH 1/1] package/crun: needs fexecve Fabrice Fontaine
2023-01-08 15:52 ` Yann E. MORIN [this message]
2023-01-12 10:23 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108155230.GD151997@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox