Re: [Buildroot] [PATCH 2/2] package/pkg-meson: generate relocatable pkgconfigs

["Yann E. MORIN" <yann.morin.1998@free.fr>]

James, All,

On 2022-07-27 19:44 -0600, James Hilliard spake thusly:
> This format prevents pkgconfig path issues when using meson's
> built-in install functionality.

"pkgconfig path issues" is vague: this is not helping understand why
this change is needed.

Please explain what is currently broken, and how that patch fixes the
issue. If there were a pointer to one or a few autobuild issues, that
would also help, and would answers Romain's question: what package(s)
is(are) impacted?

If I look at the pointer Romain provided, it states:

    https://mesonbuild.com/Pkgconfig-module.html#relocatable-pkgconfig-files

    By default, the files generated by pkg.generate contain a hardcoded
    prefix path.

Sure, I can see how that could be an issue. However, we already have two
ways to fix that:

  - for per-package directory, we have a generic fixup that replaces the
    PPD base with the one for the current package, see:
      - package/pkg-generic.mk lines 95-onward and 109-onward.
      - b06294e9897e core/pkg-generic: fixup all PPD paths in a generic fashion

  - for the SDK, we have a similar fixup, see:
      - Makefile lines 597-onward
      - support/misc/relocate-sdk.sh

So, if those fixups are not enough, can you describe what they are
missing, so that we can extend them?

This does not mean we can't apply this change (I even think it would be
OK), but we really need to understand why we need it.

Regards,
Yann E. MORIN.

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/pkg-meson.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
> index 156b005fdd..1830c7b10c 100644
> --- a/package/pkg-meson.mk
> +++ b/package/pkg-meson.mk
> @@ -134,6 +134,7 @@ define $(2)_CONFIGURE_CMDS
>  	CXX_FOR_BUILD="$$(HOSTCXX)" \
>  	$$($$(PKG)_CONF_ENV) \
>  	$$(MESON) \
> +		--pkgconfig.relocatable \
>  		--prefix=/usr \
>  		--libdir=lib \
>  		--default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
> @@ -154,6 +155,7 @@ define $(2)_CONFIGURE_CMDS
>  	mkdir -p $$($$(PKG)_SRCDIR)/build
>  	$$(HOST_CONFIGURE_OPTS) \
>  	$$($$(PKG)_CONF_ENV) $$(MESON) \
> +		--pkgconfig.relocatable \
>  		--prefix=$$(HOST_DIR) \
>  		--libdir=lib \
>  		--sysconfdir=$$(HOST_DIR)/etc \
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot